char.IsAscii xml doc comments

[gfoidl]

Cf. #40936 (comment)

I based the text on

runtime/src/libraries/System.Private.CoreLib/src/System/Text/UnicodeUtility.cs

Line 120 in 2d463ee

public static bool IsAsciiCodePoint(uint value) => value <= 0x7Fu;

(to be consistent).

/cc: @danmosemsft

[Dotnet-GitSync-Bot]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Hello @danmosemsft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[danmoseley]

@ericstj the Directory Services tests failed here with "dotnet: ../nptl/pthread_mutex_lock.c:79: __pthread_mutex_lock: Assertion `mutex->__data.__owner == 0' failed."

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-41753-merge-2af03627976d4a0e90/System.DirectoryServices.Protocols.Tests/console.b857dc64.log?sv=2019-02-02&se=2020-09-22T23%3A41%3A08Z&sr=c&sp=rl&sig=rlEe4KUr1980kVhPuLNk3GLyPlJ17N17jB6rJcGPPuo%3D

https://dev.azure.com/dnceng/public/_build/results?buildId=799437&view=ms.vss-test-web.build-test-results-tab&runId=25303434&resultId=181787&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

Which is unfortunate as it suggests taht #41053 was not a complete fix for this.

[danmoseley]

cc @joperezr

[danmoseley]

We didn't get a dump, and this was Ubuntu 18.04 which has been unwilling to give us dumps in the past.

@HaoK do you now get dumps on Ubuntu 1804 in your test runs? I see I see https://github.com/dotnet/core-eng/issues/10616 was closed.,

I really don't like getting dumps.

https://dev.azure.com/dnceng/public/_build/results?buildId=799437&view=ms.vss-test-web.build-test-results-tab&runId=25303434&resultId=181787&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

  Starting:    System.DirectoryServices.Protocols.Tests (parallel test collections = on, max threads = 2)
dotnet: ../nptl/pthread_mutex_lock.c:79: __pthread_mutex_lock: Assertion `mutex->__data.__owner == 0' failed.
./RunTests.sh: line 161:  2388 Aborted                 "$RUNTIME_PATH/dotnet" exec --runtimeconfig System.DirectoryServices.Protocols.Tests.runtimeconfig.json --depsfile System.DirectoryServices.Protocols.Tests.deps.json xunit.console.dll System.DirectoryServices.Protocols.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing $RSP_FILE
~/work/A2F708F9/w/A4C80883/e
----- end Wed Sep 2 23:43:16 UTC 2020 ----- exit code 134 ----------------------------------------------------------
exit code 134 means SIGABRT Abort. Managed or native assert, or runtime check such as heap corruption, caused call to abort(). Core dumped.
Waiting a few seconds for any dump to be written..
Looking around for any Linux dump..
... found no dump in /home/helixbot/work/A2F708F9/w/A4C80883/e
+ export _commandExitCode=134

[HaoK]

I reopened it, on my prototype we get managed dmps but cores are sometimes missing

[danmoseley]

Thanks @gfoidl