fix failing revocation & ssl tests #38827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
Member
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bartonjs
reviewed
Jul 7, 2020
...libraries/Common/tests/System/Security/Cryptography/X509Certificates/CertificateAuthority.cs
Outdated
Show resolved
Hide resolved
...libraries/Common/tests/System/Security/Cryptography/X509Certificates/CertificateAuthority.cs
Outdated
Show resolved
Hide resolved
| eeKey, | ||
| altName); | ||
| endEntityCert = endEntityIsServer ? | ||
| intermediateAuthority.CreateServerEndEntity( |
Member
There was a problem hiding this comment.
Really this feels like it should just take an OidCollection or Oid or string, rather than using a bit in the PkiOptions.
Member
Author
There was a problem hiding this comment.
I was thinking about adding bool to BuildPrivatePki() but OidCollection seems like better option. I think more variations are yet to come.
Member
Author
|
I added collection and moved altName to SslStream helper. I think that will give us more flexibility to also add IPs if we need to. |
Member
Author
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bartonjs
approved these changes
Jul 7, 2020
Member
|
Yay for code reuse. Thanks, @wfurt. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix tests broken by #38182.
This adds fork for Ssl server leaving revocation tests as before.
It adds keySize parameter to avoid failures on Debian 10 (requiring stronger crypto)
fixes #38805
fixes #38744