Skip to content
Merged
Show file tree
Hide file tree
Changes from 59 commits
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
6c2096d
libraries -restore for vertical build without test restore
Anipik Jan 3, 2020
bef5de2
Automatic test change and regex to remove the addition of an extra li…
Anipik Jan 3, 2020
150cdbb
manual test restore fixed (restore completely done for vertical build)
Anipik Jan 3, 2020
3ac3ed0
build native done
Anipik Jan 3, 2020
72281f9
Automatic ref change and regex to remove the last line
Anipik Jan 3, 2020
595f22a
manual reference assebly change and generated shims build
Anipik Jan 3, 2020
3977593
automatic src change and regex
Anipik Jan 3, 2020
49edda8
native bin place and src build manual change
Anipik Jan 4, 2020
0f21d2a
apicompat and pretest.csproj done
Anipik Jan 6, 2020
8975120
fixing the package build
Anipik Jan 7, 2020
692771b
fixing all config
Anipik Jan 14, 2020
c524f89
packaging and feedback
Anipik Jan 14, 2020
222f030
adding back placeholder configuration
Anipik Jan 14, 2020
2ca2a2c
fixing the shims
Anipik Jan 15, 2020
8de48e7
delete configuration.props
Anipik Jan 15, 2020
34c2f97
Merge branch 'master' into FinalVersion
Anipik Jan 15, 2020
e569069
making the build work in master
Anipik Jan 16, 2020
62777a1
Merge branch 'master' into FinalVersion
Anipik Jan 16, 2020
ecc1f15
Merge branch 'master' into FinalVersion
Anipik Jan 16, 2020
f7d8543
Test Change
Anipik Jan 16, 2020
a902bb5
fixing the packageing, test restore replacing TargetFramework -> Orig…
Anipik Jan 17, 2020
61fe13e
Merge branch 'master' into FinalVersion
Anipik Jan 17, 2020
68489be
delete test configuraiton.props, trailing semicolon and use targetFra…
Anipik Jan 17, 2020
0069d9c
reverting the package change
Anipik Jan 17, 2020
d1c056b
enable apicompat and fixing configurationGroup for individual projects
Anipik Jan 17, 2020
3ee0d8e
fixing the api compat
Anipik Jan 17, 2020
8456e17
making ilproj work
Anipik Jan 21, 2020
787c782
adding the outerBuildTest
Anipik Jan 24, 2020
b60994f
adding the arcade package version
Anipik Jan 24, 2020
c445e78
Merge branch 'master' into FinalVersion
Anipik Jan 24, 2020
90ae26e
fixing the merge conflicts
Anipik Jan 24, 2020
3458e02
minor changes
Anipik Jan 24, 2020
5ba40bd
adding additional configs and setting the runtimeOS
Anipik Jan 24, 2020
b0a5046
making the vs stuff work
Anipik Jan 25, 2020
4e65e57
removing the target Group to fix the apicompat
Anipik Jan 25, 2020
45fd366
fixing the linux build and some minor changes
Anipik Jan 27, 2020
bec246a
Merge branch 'master' into FinalVersion
Anipik Jan 27, 2020
849fe09
making additionalBuildTargetFramework LOcalProperty
Anipik Jan 27, 2020
afa4256
Merge branch 'master' into FinalVersion
Anipik Jan 27, 2020
0e3cab0
fixing the allConfigurations build
Anipik Jan 28, 2020
1c7f147
Merge branch 'master' into FinalVersion
Anipik Jan 28, 2020
6d16c5a
fixing the netfx build
Anipik Jan 28, 2020
b0bb93b
Merge branch 'master' into FinalVersion
Anipik Jan 28, 2020
c32d5a4
fixing package Testing and restore
Anipik Jan 29, 2020
a03b762
Merge branch 'master' into FinalVersion
Anipik Jan 29, 2020
6b184ba
Missing TargetFrameworks tag
Anipik Jan 29, 2020
fdd2265
making the VSdesgin stuff work
Anipik Jan 30, 2020
3a4ac68
Remove OriginalFramework Entirely
Anipik Jan 30, 2020
b76dc5d
Merge branch 'master' into FinalVersion
Anipik Jan 30, 2020
b7da331
some minor pr feedback
Anipik Jan 30, 2020
d4f54a3
RemoveExtraSemicolon
Anipik Jan 30, 2020
b9a76d5
use boolean exclude flag
Anipik Jan 30, 2020
2242342
fixing yml scripts to pass tests
Anipik Jan 30, 2020
7dad861
adding comments and some minor feedback
Anipik Jan 31, 2020
5ca2929
Merge branch 'master' into FinalVersion
Anipik Jan 31, 2020
83725b6
moving packaging property to correct plave
Anipik Jan 31, 2020
0b00f3f
fixing the build for web assembly
Anipik Jan 31, 2020
f5c310c
Fixing the live ci build
Anipik Jan 31, 2020
e100d84
Fixing the live build for shims
Anipik Jan 31, 2020
11f7c5e
fixing the tests
Anipik Jan 31, 2020
e98bbfc
fixing the packaging and enterprise linux
Anipik Feb 1, 2020
e956adb
fixing package sizes
Anipik Feb 4, 2020
c276cd8
Merge branch 'master' into FinalVersion
Anipik Feb 4, 2020
dcf3365
Merge branch 'master' into FinalVersion
Anipik Feb 4, 2020
ae4143a
Fix the targetFramework
Anipik Feb 4, 2020
912e0d9
Merge branch 'master' into FinalVersion
Anipik Feb 4, 2020
c0fc453
updating the targetFramework sdl
Anipik Feb 4, 2020
b5638cd
Merge branch 'master' into FinalVersion
Anipik Feb 4, 2020
410341f
removing the buildOS and be able to use OSGroup as done in the old sy…
Anipik Feb 5, 2020
4919a86
Merge branch 'master' into FinalVersion
Anipik Feb 5, 2020
38c4c30
Merge branch 'master' into FinalVersion
Anipik Feb 5, 2020
ddadd6b
Fixing the osgroup stuff for send to helix task
Anipik Feb 5, 2020
d59e375
Fix OSX failures
Anipik Feb 5, 2020
e4afb57
Merge branch 'master' into FinalVersion
Anipik Feb 5, 2020
29ece31
Fixing the osx build
Anipik Feb 5, 2020
a22bf93
Merge branch 'master' into FinalVersion
Anipik Feb 5, 2020
b6fa06c
uploading tmp folder to artifacts
Anipik Feb 6, 2020
5b521c2
running restore for runtime.deproj correctly
Anipik Feb 6, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 4 additions & 0 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>8466781af43871ee0d4a1655acc008a305a62c0e</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk" Version="5.0.0-beta.20079.8">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>8466781af43871ee0d4a1655acc008a305a62c0e</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.RemoteExecutor" Version="5.0.0-beta.20079.8">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>8466781af43871ee0d4a1655acc008a305a62c0e</Sha>
Expand Down
2 changes: 1 addition & 1 deletion eng/build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ foreach ($argument in $PSBoundParameters.Keys)
"test" { $arguments += " -test" }
"configuration" { $configuration = (Get-Culture).TextInfo.ToTitleCase($($PSBoundParameters[$argument])); $arguments += " /p:ConfigurationGroup=$configuration -configuration $configuration" }
"runtimeConfiguration" { $arguments += " /p:RuntimeConfiguration=$((Get-Culture).TextInfo.ToTitleCase($($PSBoundParameters[$argument])))" }
"framework" { $arguments += " /p:TargetGroup=$($PSBoundParameters[$argument].ToLowerInvariant())" }
"framework" { $arguments += " /p:BuildTargetFramework=$($PSBoundParameters[$argument].ToLowerInvariant())" }
"os" { $arguments += " /p:OSGroup=$($PSBoundParameters[$argument])" }
"allconfigurations" { $arguments += " /p:BuildAllConfigurations=true" }
"arch" { $arguments += " /p:ArchGroup=$($PSBoundParameters[$argument]) /p:TargetArchitecture=$($PSBoundParameters[$argument])" }
Expand Down
2 changes: 1 addition & 1 deletion eng/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ while [[ $# > 0 ]]; do
;;
-framework|-f)
val="$(echo "$2" | awk '{print tolower($0)}')"
arguments="$arguments /p:TargetGroup=$val"
arguments="$arguments /p:BuildTargetFramework=$val"
shift 2
;;
-os)
Expand Down
10 changes: 0 additions & 10 deletions eng/configurations/archgroups.props

This file was deleted.

6 changes: 0 additions & 6 deletions eng/configurations/configurationgroups.props

This file was deleted.

46 changes: 0 additions & 46 deletions eng/configurations/osgroups.props

This file was deleted.

49 changes: 0 additions & 49 deletions eng/configurations/properties.props

This file was deleted.

175 changes: 0 additions & 175 deletions eng/configurations/targetgroups.props

This file was deleted.

5 changes: 5 additions & 0 deletions eng/depProj.common.targets
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information. -->
<Project>
<Import Condition="'$(IsCrossTargetingBuild)' != 'true'" Project="depProj.targets" />
<Import Condition="'$(IsCrossTargetingBuild)' == 'true'" Project="$(MSBuildExtensionsPath)Microsoft.Common.CrossTargeting.targets" />
</Project>
3 changes: 3 additions & 0 deletions eng/depProj.targets
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ See the LICENSE file in the project root for more information.
<CopyNuGetImplementations>true</CopyNuGetImplementations>
</PropertyGroup>

<!-- This file results in importing the Build Target. -->
<Import Project="$(MSBuildToolsPath)\Microsoft.Common.targets" />

<Target Name="RemoveImplicitPackageReferences">
<ItemGroup>
<!-- Remove all implicit framework packages, depprojs are meant to be wholly explicit -->
Expand Down
14 changes: 7 additions & 7 deletions eng/illink.targets
Original file line number Diff line number Diff line change
Expand Up @@ -35,23 +35,23 @@
Must be enabled by setting BinPlaceILLinkTrimAssembly=true
-->
<ItemGroup Condition="'$(BinPlaceILLinkTrimAssembly)' == 'true'">
<BinPlaceConfiguration Include="$(BuildConfiguration)">
<BinPlaceTargetFramework Include="$(BuildConfiguration)">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should BuildConfiguration here be replaced with something?

<RuntimePath>$(ArtifactsBinDir)ILLinkTrimAssembly/$(BuildConfiguration)/trimmed</RuntimePath>
<ItemName>TrimmedItem</ItemName>
</BinPlaceConfiguration>
<BinPlaceConfiguration Include="$(BuildConfiguration)">
</BinPlaceTargetFramework>
<BinPlaceTargetFramework Include="$(BuildConfiguration)">
<RuntimePath>$(ArtifactsBinDir)ILLinkTrimAssembly/$(BuildConfiguration)/reports</RuntimePath>
<ItemName>TrimmingReport</ItemName>
</BinPlaceConfiguration>
<BinPlaceConfiguration Include="$(BuildConfiguration)">
</BinPlaceTargetFramework>
<BinPlaceTargetFramework Include="$(BuildConfiguration)">
<RuntimePath>$(ArtifactsBinDir)ILLinkTrimAssembly/$(BuildConfiguration)/pretrimmed</RuntimePath>
<ItemName>PreTrimmedItem</ItemName>
</BinPlaceConfiguration>
</BinPlaceTargetFramework>
</ItemGroup>

<Target Name="_SetILLinkTrimAssembly"
Condition="'$(ILLinkTrimAssembly)' == ''"
DependsOnTargets="GetBinPlaceConfiguration">
DependsOnTargets="GetBinPlaceTargetFramework">
<PropertyGroup>
<!-- Currently ILLink cannot handle type projections from Windows.winmd, disable if the project references it -->
<ILLinkTrimAssembly Condition="'%(ReferencePath.FileName)%(ReferencePath.Extension)' == 'Windows.winmd'">false</ILLinkTrimAssembly>
Expand Down
6 changes: 3 additions & 3 deletions eng/liveBuilds.targets
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<Project>

<PropertyGroup>
<CoreCLROSGroup Condition="'$(CoreCLROSGroup)' == ''">$(OSGroup)</CoreCLROSGroup>
<MonoOSGroup Condition="'$(MonoOSGroup)' == ''">$(OSGroup)</MonoOSGroup>
<LibrariesOSGroup Condition="'$(LibrariesOSGroup)' == ''">$(OSGroup)</LibrariesOSGroup>
<CoreCLROSGroup Condition="'$(CoreCLROSGroup)' == ''">$(BuildOS)</CoreCLROSGroup>
<MonoOSGroup Condition="'$(MonoOSGroup)' == ''">$(BuildOS)</MonoOSGroup>
<LibrariesOSGroup Condition="'$(LibrariesOSGroup)' == ''">$(BuildOS)</LibrariesOSGroup>
<LibrariesConfiguration Condition="'$(LibrariesConfiguration)' == ''">$(Configuration)</LibrariesConfiguration>

<LibrariesOSGroupConfigurationArchitecture Condition="'$(LibrariesOSGroupConfigurationArchitecture)' == ''">$(LibrariesOSGroup)-$(LibrariesConfiguration)-$(TargetArchitecture)</LibrariesOSGroupConfigurationArchitecture>
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/libraries/base-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:

- ${{ if ne(parameters.framework, '') }}:
- _finalFrameworkArg: -framework ${{ parameters.framework }}
- _extraHelixArguments: /p:TargetGroup=${{ parameters.framework }}
- _extraHelixArguments: /p:BuildTargetFramework=${{ parameters.framework }}

- ${{ if eq(parameters.framework, 'allConfigurations') }}:
- _finalFrameworkArg: -allConfigurations
Expand Down
Loading