-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New Configuration System #1787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
New Configuration System #1787
Changes from 18 commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
6c2096d
libraries -restore for vertical build without test restore
Anipik bef5de2
Automatic test change and regex to remove the addition of an extra li…
Anipik 150cdbb
manual test restore fixed (restore completely done for vertical build)
Anipik 3ac3ed0
build native done
Anipik 72281f9
Automatic ref change and regex to remove the last line
Anipik 595f22a
manual reference assebly change and generated shims build
Anipik 3977593
automatic src change and regex
Anipik 49edda8
native bin place and src build manual change
Anipik 0f21d2a
apicompat and pretest.csproj done
Anipik 8975120
fixing the package build
Anipik 692771b
fixing all config
Anipik c524f89
packaging and feedback
Anipik 222f030
adding back placeholder configuration
Anipik 2ca2a2c
fixing the shims
Anipik 8de48e7
delete configuration.props
Anipik 34c2f97
Merge branch 'master' into FinalVersion
Anipik e569069
making the build work in master
Anipik 62777a1
Merge branch 'master' into FinalVersion
Anipik ecc1f15
Merge branch 'master' into FinalVersion
Anipik f7d8543
Test Change
Anipik a902bb5
fixing the packageing, test restore replacing TargetFramework -> Orig…
Anipik 61fe13e
Merge branch 'master' into FinalVersion
Anipik 68489be
delete test configuraiton.props, trailing semicolon and use targetFra…
Anipik 0069d9c
reverting the package change
Anipik d1c056b
enable apicompat and fixing configurationGroup for individual projects
Anipik 3ee0d8e
fixing the api compat
Anipik 8456e17
making ilproj work
Anipik 787c782
adding the outerBuildTest
Anipik b60994f
adding the arcade package version
Anipik c445e78
Merge branch 'master' into FinalVersion
Anipik 90ae26e
fixing the merge conflicts
Anipik 3458e02
minor changes
Anipik 5ba40bd
adding additional configs and setting the runtimeOS
Anipik b0a5046
making the vs stuff work
Anipik 4e65e57
removing the target Group to fix the apicompat
Anipik 45fd366
fixing the linux build and some minor changes
Anipik bec246a
Merge branch 'master' into FinalVersion
Anipik 849fe09
making additionalBuildTargetFramework LOcalProperty
Anipik afa4256
Merge branch 'master' into FinalVersion
Anipik 0e3cab0
fixing the allConfigurations build
Anipik 1c7f147
Merge branch 'master' into FinalVersion
Anipik 6d16c5a
fixing the netfx build
Anipik b0bb93b
Merge branch 'master' into FinalVersion
Anipik c32d5a4
fixing package Testing and restore
Anipik a03b762
Merge branch 'master' into FinalVersion
Anipik 6b184ba
Missing TargetFrameworks tag
Anipik fdd2265
making the VSdesgin stuff work
Anipik 3a4ac68
Remove OriginalFramework Entirely
Anipik b76dc5d
Merge branch 'master' into FinalVersion
Anipik b7da331
some minor pr feedback
Anipik d4f54a3
RemoveExtraSemicolon
Anipik b9a76d5
use boolean exclude flag
Anipik 2242342
fixing yml scripts to pass tests
Anipik 7dad861
adding comments and some minor feedback
Anipik 5ca2929
Merge branch 'master' into FinalVersion
Anipik 83725b6
moving packaging property to correct plave
Anipik 0b00f3f
fixing the build for web assembly
Anipik f5c310c
Fixing the live ci build
Anipik e100d84
Fixing the live build for shims
Anipik 11f7c5e
fixing the tests
Anipik e98bbfc
fixing the packaging and enterprise linux
Anipik e956adb
fixing package sizes
Anipik c276cd8
Merge branch 'master' into FinalVersion
Anipik dcf3365
Merge branch 'master' into FinalVersion
Anipik ae4143a
Fix the targetFramework
Anipik 912e0d9
Merge branch 'master' into FinalVersion
Anipik c0fc453
updating the targetFramework sdl
Anipik b5638cd
Merge branch 'master' into FinalVersion
Anipik 410341f
removing the buildOS and be able to use OSGroup as done in the old sy…
Anipik 4919a86
Merge branch 'master' into FinalVersion
Anipik 38c4c30
Merge branch 'master' into FinalVersion
Anipik ddadd6b
Fixing the osgroup stuff for send to helix task
Anipik d59e375
Fix OSX failures
Anipik e4afb57
Merge branch 'master' into FinalVersion
Anipik 29ece31
Fixing the osx build
Anipik a22bf93
Merge branch 'master' into FinalVersion
Anipik b6fa06c
uploading tmp folder to artifacts
Anipik 5b521c2
running restore for runtime.deproj correctly
Anipik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information. --> | ||
| <Project> | ||
| <Import Condition="'$(IsCrossTargetingBuild)' != 'true'" Project="depProj.targets" /> | ||
| <Import Condition="'$(IsCrossTargetingBuild)' == 'true'" Project="$(MSBuildExtensionsPath)Microsoft.Common.CrossTargeting.targets" /> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,23 +35,23 @@ | |
| Must be enabled by setting BinPlaceILLinkTrimAssembly=true | ||
| --> | ||
| <ItemGroup Condition="'$(BinPlaceILLinkTrimAssembly)' == 'true'"> | ||
| <BinPlaceConfiguration Include="$(BuildConfiguration)"> | ||
| <BinPlaceTargetFramework Include="$(BuildConfiguration)"> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should BuildConfiguration here be replaced with something? |
||
| <RuntimePath>$(ArtifactsBinDir)ILLinkTrimAssembly/$(BuildConfiguration)/trimmed</RuntimePath> | ||
| <ItemName>TrimmedItem</ItemName> | ||
| </BinPlaceConfiguration> | ||
| <BinPlaceConfiguration Include="$(BuildConfiguration)"> | ||
| </BinPlaceTargetFramework> | ||
| <BinPlaceTargetFramework Include="$(BuildConfiguration)"> | ||
| <RuntimePath>$(ArtifactsBinDir)ILLinkTrimAssembly/$(BuildConfiguration)/reports</RuntimePath> | ||
| <ItemName>TrimmingReport</ItemName> | ||
| </BinPlaceConfiguration> | ||
| <BinPlaceConfiguration Include="$(BuildConfiguration)"> | ||
| </BinPlaceTargetFramework> | ||
| <BinPlaceTargetFramework Include="$(BuildConfiguration)"> | ||
| <RuntimePath>$(ArtifactsBinDir)ILLinkTrimAssembly/$(BuildConfiguration)/pretrimmed</RuntimePath> | ||
| <ItemName>PreTrimmedItem</ItemName> | ||
| </BinPlaceConfiguration> | ||
| </BinPlaceTargetFramework> | ||
| </ItemGroup> | ||
|
|
||
| <Target Name="_SetILLinkTrimAssembly" | ||
| Condition="'$(ILLinkTrimAssembly)' == ''" | ||
| DependsOnTargets="GetBinPlaceConfiguration"> | ||
| DependsOnTargets="GetBinPlaceTargetFramework"> | ||
| <PropertyGroup> | ||
| <!-- Currently ILLink cannot handle type projections from Windows.winmd, disable if the project references it --> | ||
| <ILLinkTrimAssembly Condition="'%(ReferencePath.FileName)%(ReferencePath.Extension)' == 'Windows.winmd'">false</ILLinkTrimAssembly> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...on/tests/CoreFx.Private.TestUtilities.Unicode/CoreFx.Private.TestUtilities.Unicode.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/libraries/Common/tests/CoreFx.Private.TestUtilities/CoreFx.Private.TestUtilities.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/libraries/Common/tests/System/Xml/BaseLibManaged/BaseLibManaged.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/libraries/Common/tests/System/Xml/ModuleCore/ModuleCore.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.