Avoid shipping libclrinterpreter in wasm runtime packs #121405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes references to the standalone libclrinterpreter.a library from WASM/browser build configurations and generalizes the interpreter installation condition from platform-specific checks to a feature-based check.
Key changes:
- Removes
libclrinterpreter.afrom WASM-specific build configurations (it's now statically linked intolibcoreclr_static.a) - Changes the interpreter installation condition from iOS/tvOS/MacCatalyst-specific to
FEATURE_STATICALLY_LINKED, which is more maintainable and includes WASM - Ensures consistency across CMake build files, packaging manifests, and live build targets
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/native/corehost/browserhost/CMakeLists.txt | Removes libclrinterpreter.a from the list of native libraries to link for the browser host |
| src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props | Removes libclrinterpreter.a from the CoreCLR WASM-specific platform manifest |
| src/coreclr/interpreter/CMakeLists.txt | Generalizes install condition from iOS/tvOS/MacCatalyst-specific to FEATURE_STATICALLY_LINKED |
| eng/liveBuilds.targets | Removes libclrinterpreter.a from browser CoreCLR runtime files list |
kotlarmilos
added
os-browser
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
pavelsavara
approved these changes
Nov 6, 2025
This was referenced Nov 6, 2025
Open
Member
|
/ba-g CI timeouts |
This was referenced Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The libclrinterpreter is already linked into the coreclr_static library for wasm in:
runtime/src/coreclr/dlls/mscoree/coreclr/CMakeLists.txt
Line 201 in e0837be
This PR updates the build to avoid shipping libclrinterpreter in the wasm runtime packs as separate static librariy, which resolves the manifest errors:
Fixes #121399