Skip to content

Fix unhandled exception test for interpreter #121397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2025
Merged

Fix unhandled exception test for interpreter #121397

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f4df73
Fix unhandled exception test for interpreter
janvorli Nov 5, 2025
550f5b5
Apply suggestions from code review
janvorli Nov 6, 2025
6bfaa2d
Apply suggestion from @janvorli
janvorli Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions src/tests/baseservices/exceptions/unhandled/unhandledTester.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,40 +40,46 @@ static void RunExternalProcess(string unhandledType, string assembly)
Console.WriteLine($"Test process {assembly} with argument {unhandledType} exited");
testProcess.CancelErrorRead();

int expectedExitCode;
int[] expectedExitCodes;
if (TestLibrary.Utilities.IsMonoRuntime)
{
expectedExitCode = 1;
expectedExitCodes = new[] { 1 };
}
else if (!OperatingSystem.IsWindows())
{
expectedExitCode = 128 + 6; // SIGABRT
expectedExitCodes = new[] { 128 + 6 }; // SIGABRT
}
else if (TestLibrary.Utilities.IsNativeAot)
{
expectedExitCode = unchecked((int)0xC0000409);
expectedExitCodes = new[] { unchecked((int)0xC0000409) };
}
else
{
if (unhandledType.EndsWith("hardware"))
{
// Null reference exception code
expectedExitCode = unchecked((int)0xC0000005);
expectedExitCodes = new[] { unchecked((int)0xC0000005), unchecked((int)0xE0434352) };
}
else if (unhandledType == "collecteddelegate")
{
// Fail fast exit code
expectedExitCode = unchecked((int)0x80131623);
expectedExitCodes = new[] { unchecked((int)0x80131623) };
}
else
{
expectedExitCode = unchecked((int)0xE0434352);
expectedExitCodes = new[] { unchecked((int)0xE0434352) };
}
}

if (expectedExitCode != testProcess.ExitCode)
if (!Array.Exists(expectedExitCodes, code => testProcess.ExitCode == code))
{
throw new Exception($"Wrong exit code 0x{testProcess.ExitCode:X8}, expected 0x{expectedExitCode:X8}");
string separator = string.Empty;
StringBuilder expectedListBuilder = new StringBuilder();
Array.ForEach(expectedExitCodes, code => {
expectedListBuilder.Append($"{separator}0x{code:X8}");
separator = " or ";
});
throw new Exception($"Wrong exit code: 0x{testProcess.ExitCode:X8}, expected {expectedListBuilder.ToString()}");
}

int exceptionStackFrameLine = 1;
Expand All @@ -97,6 +103,13 @@ static void RunExternalProcess(string unhandledType, string assembly)
throw new Exception("Missing exception type and message");
}
}
else if (unhandledType.EndsWith("hardware"))
{
if (lines[1] != "System.NullReferenceException: Object reference not set to an instance of an object.")
{
throw new Exception("Missing exception type and message");
}
}

exceptionStackFrameLine = 2;
}
Expand Down
Loading