[mono][sgen] Add option to disable tarjan gc bridge optimization #121243
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option is also currently causing crashes in the gc bridge.
|
Tagging subscribers to this area: @BrzVlad |
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an indexing bug in the Tarjan bridge color table dump function and adds a new GC parameter option for disabling non-bridge strongly connected components (SCCs).
- Fixed incorrect loop counter increment in
dump_color_tablefunction - Added support for
disable-non-bridge-sccGC parameter option
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mono/mono/metadata/sgen-tarjan-bridge.c | Moved counter increment from outer loop to inner loop to correctly count color data entries instead of buckets |
| src/mono/mono/metadata/sgen-bridge.c | Added parameter handling for the disable-non-bridge-scc configuration option |
filipnavara
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is also currently causing crashes in the gc bridge.