Revert "[release/8.0] Bump STJ and MSBuild Version" (#121123) #121126
+28
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts #119859 VS17.10 can't support 8.0.5 and as a result this change needs to be backed out.
|
Hotfix port direct to 8.0 |
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous version bump for System.Text.Json and MSBuild packages due to Visual Studio 17.10 compatibility issues. The revert downgrades multiple package versions from 8.0.10/8.0.5 back to 8.0.0-rc.1.23406.6 and associated release candidate versions.
Key Changes:
- Reverts MSBuild version from 17.8.43 back to 17.8.3
- Reverts System.Text.Json from 8.0.5 to 7.0.3 (toolset) and 8.0.0-rc.1.23406.6 (runtime)
- Reverts multiple runtime components (ILAsm, ILLink, ILCompiler) to RC1 versions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| global.json | Reverts Microsoft.NET.Sdk.IL to RC1 version for SDK compatibility |
| eng/Versions.props | Downgrades package versions for MSBuild, System.Text.Json, and multiple runtime dependencies |
| eng/Version.Details.xml | Updates dependency metadata with corresponding SHA references for the reverted versions |
| <!-- CoreClr dependencies --> | ||
| <MicrosoftNETCoreILAsmVersion>8.0.10-servicing.24466.9</MicrosoftNETCoreILAsmVersion> | ||
| <MicrosoftNETCoreILAsmVersion>8.0.0-rc.1.23406.6</MicrosoftNETCoreILAsmVersion> | ||
| <MicrosoftNETCoreILAsmVersion>8.0.0-preview.7.23325.2</MicrosoftNETCoreILAsmVersion> |
There was a problem hiding this comment.
Duplicate property definition for MicrosoftNETCoreILAsmVersion. Line 112 overwrites the value set on line 111, making the revert on line 111 ineffective. Remove the duplicate on line 112 or resolve which version should be used.
Suggested change
| <MicrosoftNETCoreILAsmVersion>8.0.0-preview.7.23325.2</MicrosoftNETCoreILAsmVersion> |
This was referenced Oct 27, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #119859
VS17.10 can't support 8.0.5 and as a result this change needs to be
backed out.