[release/10.0] Mark labels in x64 write barrier code as local/alt_entry #120923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncorrect transformations by the ld64/ld-prime linkers
rbhanda
added
Servicing-approved
agocke
approved these changes
Oct 21, 2025
|
/ba-g Helix definitions are outdated. Runs are failing due to missing machines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119245 to release/10.0
/cc @agocke @filipnavara
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
This is a regression in the new Apple toolset.
Testing
Tested manually, and in macios CI.
Risk
Medium, product change coming somewhat late. However, this change has been running in the
mainbranch for a couple weeks with no issue.