-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[browser] build more subsets + runtime interp test #120359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/azp run runtime |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run runtime |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run runtime |
|
Azure Pipelines failed to run 1 pipeline(s). |
Co-authored-by: SingleAccretion <[email protected]>
1bfc7c8 to
90eb1c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables building more subsets for the browser target and adds runtime interpreter tests for WebAssembly. The main goal is to expand CI capabilities for browser builds by switching from clr.runtime+libs to the full clr+libs subset and building JIT interpreter tests specifically for WASM.
Key changes:
- Switch browser builds to use the full
clr+libssubset in Release configuration - Enable native test building for browser targets by parameterizing library types
- Add conditional compilation for WASM interpreter tests with fallback behavior
Reviewed Changes
Copilot reviewed 122 out of 122 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/runtime.yml | Updates browser build to use clr+libs subset and adds interpreter test build step |
| src/tests/CMakeLists.txt | Adds WASM-specific configuration with static library type and compiler flags |
| src/tests/JIT/interpreter/Interpreter.cs | Adds WASM-specific early return and P/Invoke conditionals |
| Multiple CMakeLists.txt files | Replaces hardcoded SHARED with ${TEST_LIB_TYPE} variable |
| Various configuration files | Updates build configurations and dependency handling for browser/WASM targets |
Co-authored-by: SingleAccretion <[email protected]>
Co-authored-by: Aaron Robinson <[email protected]>
Co-authored-by: Aaron Robinson <[email protected]>
Purpose: make
clr+libsto build, make runtime tests to build for wasm, but this PR is not trying to run it yet.clr+libson CIReleasebecause that's whatsrc/testsneed, witch coreclr to Debug, because that works.jitinterface_wasm.dlldependencyclr.nativecorelibsubset from browsereng/liveBuilds.targetsmono specific, disable part temporarilyhost.nativesubset temporarilysrc/tests/JIT/interpreter/on CIset(TEST_LIB_TYPE STATIC)for WASM andset(TEST_LIB_TYPE SHARED)for otherssrc/mono/llvm/llvm-init.projfor windows debug