-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[browser] Use WebAssembly SDK for runtime tests #120330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
maraf
wants to merge
34
commits into
dotnet:main
Choose a base branch
from
maraf:WasmSdkInTree2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@javiercn Does it ring any bell?
|
This was referenced Oct 3, 2025
Open
This was referenced Oct 21, 2025
This was referenced Oct 23, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD
Fixes to #103025
TODO
<Content Link="..."copy the assembly to the publish output early enough, so that it gets picked up toWasmAssembliesToBundleand so the AOT compiler gets itNetCoreServerandRemoteLoopServerGetCurrentProjectBuildStaticWebAssetItemsWasmExtraFilesToDeployfrom testsWasmFilesToIncludeInFileSystem- We needed coreVfs for runtimeConfig, but we have that solved now by embedding it into the boot manifest. I think we can drop coreVfs. The challenge is that VFS items hastargetPathas well, so SWA standard properties aren't enoughIncludeSatelliteAssembliesInVFSbrowser-wasm linux Release LibraryTests_EATProxyProjectForAOTOnHelix.projis usingWasmApp.LocalBuild.props/targetsWasmAppDir<OutputType Condition="'$(OutputType)' == ''">exe</OutputType>inMicrosoft.NET.Sdk.WebAssembly.Browser.propsis too relaxed as at the point the default value oflibraryis already supplied by general SDK propsStartupHookForFunctionalTest.csproj