Avoid logging lengthy StringBuilder in System.IO.Tests #120164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes XUnit test logging by replacing lengthy StringBuilder arguments with an enum in System.IO.Tests to prevent large test data from being included in test logs. The change reduces log size from 2.5MB to 0.5MB while maintaining the same test coverage.
- Introduces
TestStringBuilderKindenum to represent different StringBuilder test scenarios - Refactors test methods to accept the enum instead of StringBuilder directly
- Adds helper method to generate StringBuilder instances based on the enum value
github-actions
bot
added
the
needs-area-label
|
I suspect that the long log file contributed to the build analysis missing the other System.IO.Tests failures in #117168 (comment) |
jkotas
added
area-System.IO
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-system-io |
stephentoub
approved these changes
Sep 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XUnit test logs include arguments of theories. Replaced lengthy StringBuilder argument in System.IO.Tests with enum to avoid polluting log with it.
System.IO.Tests log size before this change: 2.5MB
System.IO.Tests log size after this change: 0,5MB