Skip to content

Fix test containing reflection erroring from #117168 (Add methods from #27912 (Flow System.Text.Rune through more APIs)) #120145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 27, 2025
Merged

Fix test containing reflection erroring from #117168 (Add methods from #27912 (Flow System.Text.Rune through more APIs)) #120145

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5c0b7af
Fix tests from #117168
Joy-less Sep 26, 2025
0e35fd6
Add `SyncTextWriter` overloads as well
Joy-less Sep 26, 2025
19d3b57
Merge branch 'dotnet:main' into fix-tests-from-rune-overloads
Joy-less Sep 26, 2025
1099bbd
Add missing overloads to BroadcastingTextWriter
Joy-less Sep 26, 2025
c4feb7e
Merge branch 'dotnet:main' into fix-tests-from-rune-overloads
Joy-less Sep 26, 2025
872b808
Reapply "Add methods from #27912 (Flow System.Text.Rune through more …
Joy-less Sep 26, 2025
2aabcc9
Override the TextWrite Rune overloads in IndentedTextWriter
tarekgh Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/IO/TextWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,6 +702,7 @@ public override void Flush() { }
public override Task FlushAsync(CancellationToken cancellationToken) => Task.CompletedTask;

public override void Write(char value) { }
public override void Write(Rune value) { }
public override void Write(char[]? buffer) { }
public override void Write(char[] buffer, int index, int count) { }
public override void Write(ReadOnlySpan<char> buffer) { }
Expand All @@ -722,12 +723,14 @@ public override void Write([StringSyntax(StringSyntaxAttribute.CompositeFormat)]
public override void Write([StringSyntax(StringSyntaxAttribute.CompositeFormat)] string format, params object?[] arg) { }
public override void Write([StringSyntax(StringSyntaxAttribute.CompositeFormat)] string format, params ReadOnlySpan<object?> arg) { }
public override Task WriteAsync(char value) => Task.CompletedTask;
public override Task WriteAsync(Rune value) => Task.CompletedTask;
public override Task WriteAsync(string? value) => Task.CompletedTask;
public override Task WriteAsync(StringBuilder? value, CancellationToken cancellationToken = default) => Task.CompletedTask;
public override Task WriteAsync(char[] buffer, int index, int count) => Task.CompletedTask;
public override Task WriteAsync(ReadOnlyMemory<char> buffer, CancellationToken cancellationToken = default) => Task.CompletedTask;
public override void WriteLine() { }
public override void WriteLine(char value) { }
public override void WriteLine(Rune value) { }
public override void WriteLine(char[]? buffer) { }
public override void WriteLine(char[] buffer, int index, int count) { }
public override void WriteLine(ReadOnlySpan<char> buffer) { }
Expand All @@ -748,6 +751,7 @@ public override void WriteLine([StringSyntax(StringSyntaxAttribute.CompositeForm
public override void WriteLine([StringSyntax(StringSyntaxAttribute.CompositeFormat)] string format, params object?[] arg) { }
public override void WriteLine([StringSyntax(StringSyntaxAttribute.CompositeFormat)] string format, params ReadOnlySpan<object?> arg) { }
public override Task WriteLineAsync(char value) => Task.CompletedTask;
public override Task WriteLineAsync(Rune value) => Task.CompletedTask;
public override Task WriteLineAsync(string? value) => Task.CompletedTask;
public override Task WriteLineAsync(StringBuilder? value, CancellationToken cancellationToken = default) => Task.CompletedTask;
public override Task WriteLineAsync(char[] buffer, int index, int count) => Task.CompletedTask;
Expand Down
Loading