Skip to content

Conversation

@pavelsavara
Copy link
Member

I hit this when my test code tried to create managed exception

@pavelsavara pavelsavara added this to the 11.0.0 milestone Sep 4, 2025
@pavelsavara pavelsavara self-assigned this Sep 4, 2025
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-VM-coreclr labels Sep 4, 2025
@pavelsavara pavelsavara marked this pull request as ready for review September 4, 2025 11:49
Copilot AI review requested due to automatic review settings September 4, 2025 11:49
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for FEATURE_PORTABLE_ENTRYPOINTS in the INTOP_CALL_HELPER_P_PA case of the CoreCLR interpreter. The change enables the interpreter to handle portable entry points by detecting when a helper function doesn't have a native entry point and redirecting to interpret the method instead of calling the native helper directly.

Key changes:

  • Modified the INTOP_CALL_HELPER_P_PA case to check for portable entry points
  • Added logic to redirect to interpreted method execution when a portable entry point is detected

Copy link
Member

@radekdoulik radekdoulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radekdoulik radekdoulik merged commit 282292c into dotnet:main Sep 5, 2025
98 checks passed
@pavelsavara pavelsavara deleted the INTOP_CALL_HELPER_P_PA branch September 10, 2025 13:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-VM-coreclr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants