Skip to content

Tweaks to warning formatting #118797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −4
Open

Tweaks to warning formatting #118797

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04dc072
Tweaks to warning formatting
MichalStrehovsky Aug 15, 2025
eea3ac2
Okay I just read what it prints
MichalStrehovsky Aug 15, 2025
c3ef256
Update RyuJitCompilation.cs
MichalStrehovsky Aug 15, 2025
20552fe
Update MessageContainer.cs
MichalStrehovsky Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Logging/MessageContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ private MessageContainer(MessageCategory category, DiagnosticId id, string subca

public string ToMSBuildString()
{
const string originApp = "ILC";
const string originApp = "ILC "; // extra space for MSBuild sake: https://github.com/dotnet/runtime/issues/118788
string origin = Origin?.ToString() ?? originApp;

StringBuilder sb = new StringBuilder();
Expand Down
6 changes: 4 additions & 2 deletions src/coreclr/tools/aot/ILCompiler.RyuJit/Compiler/RyuJitCompilation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,16 +213,18 @@ private void CompileSingleMethod(CorInfoImpl corInfo, MethodCodeNode methodCodeN

if (exception != null)
{
var mdOwningType = method.OwningType as MetadataType;
string owningAssembly = mdOwningType?.Module?.Assembly?.GetName()?.Name ?? "<unknown>";
Copy link

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The assembly name extraction logic uses multiple null-conditional operators in sequence, which could be simplified for better readability. Consider extracting this into a helper method or using a more explicit approach to handle the null cases.

Copilot uses AI. Check for mistakes.
if (exception is TypeSystemException.InvalidProgramException
&& method.OwningType is MetadataType mdOwningType
&& mdOwningType != null
&& mdOwningType.HasCustomAttribute("System.Runtime.InteropServices", "ClassInterfaceAttribute"))
{
Logger.LogWarning(method, DiagnosticId.COMInteropNotSupportedInFullAOT);
}
if ((_compilationOptions & RyuJitCompilationOptions.UseResilience) != 0)
Logger.LogMessage($"Method '{method}' will always throw because: {exception.Message}");
else
Logger.LogError($"Method will always throw because: {exception.Message}", 1005, method, MessageSubCategory.AotAnalysis);
Logger.LogError($"Method in '{owningAssembly}' will always throw because: {exception.Message}", 1005, method, MessageSubCategory.AotAnalysis);

// Try to compile the method again, but with a throwing method body this time.
MethodIL throwingIL = TypeSystemThrowingILEmitter.EmitIL(method, exception);
Expand Down
Loading