-
Couldn't load subscription status.
- Fork 5.2k
[PQC] Update tests for latest Win11 Insiders #118612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PQC] Update tests for latest Win11 Insiders #118612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates tests for Post-Quantum Cryptography (PQC) algorithms to support the latest Windows 11 Insider builds (build 27919), which fixes issues #116463 and #116461 but introduces a new issue #118609. The changes update test conditions and add necessary flags to ensure proper key loading behavior.
Key changes:
- Updates test conditions to use
MLDsa.IsSupportedinstead of Windows-specific conditions for tests that are now working on Windows - Adds
X509KeyStorageFlags.Exportableflag to X509 certificate loading calls throughout the codebase - Introduces new conditional test attributes to handle the new Windows limitation (#118609) for PKCS#8 export functionality
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxTests.cs |
Removes unused imports, updates test conditions for MLDsa tests, and adds Exportable flag to certificate loading calls |
src/libraries/System.Security.Cryptography/tests/X509Certificates/ExportTests.cs |
Removes unused imports, updates test conditions, and adds Exportable flag to certificate loading |
src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/MLDsa/MLDsaTestsBase.cs |
Updates test conditions from Windows-specific to general support checks and adds new issue tracking |
src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/MLDsa/MLDsaTestHelpers.cs |
Simplifies helper methods by removing Windows-specific PKCS#8 format conversion code |
src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/MLDsa/MLDsaCngTests.Windows.cs |
Updates test conditions to handle new Windows limitation |
src/libraries/Common/src/System/Security/Cryptography/MLDsaPkcs8.cs |
Removes old PKCS#8 format conversion methods no longer needed |
src/libraries/Common/src/System/Security/Cryptography/MLDsaCng.Windows.cs |
Removes fallback code for old PKCS#8 format conversion |
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want any of the three related issues to have ActiveIssue presence in the tests, both the old problems and the new one are controlled by ConditionalFact/ConditionalTheory, and having two different suppressions in place just makes things harder to maintain (as evidenced by some of the old ActiveIssue values still being present)
...n/tests/System/Security/Cryptography/AlgorithmImplementations/MLDsa/MLDsaCngTests.Windows.cs
Outdated
Show resolved
Hide resolved
...s/Common/tests/System/Security/Cryptography/AlgorithmImplementations/MLDsa/MLDsaTestsBase.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxTests.cs
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/X509Certificates/PfxTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can remove those last two Exportable, great. If not, fine 😄.
Windows 11 Insider Canary Channel build 27919 fixes #116463 and #116461 and introduces #118609.