Disable some TimeZoneInfoTests on Android #118329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 4, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily disables specific TimeZoneInfo tests on Android and refactors platform detection logic to address CI failures caused by Android device updates that changed timezone display name formatting.
Key changes:
- Disables
NoBackwardTimeZonestest on Android platform usingActiveIssueattribute - Refactors Apple mobile platform condition to use
PlatformDetection.IsAppleMobilefor cleaner code - Conditionally excludes Sydney timezone test data on Android due to inconsistent display name formatting
tarekgh
reviewed
Aug 5, 2025
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/TimeZoneInfoTests.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Aug 5, 2025
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/TimeZoneInfoTests.cs
Outdated
Show resolved
Hide resolved
+ disable NoBackwardTimeZones test on Android
matouskozak
force-pushed
the
disable-timezonetests-android
branch
from
ba7d752 to
e091959
Compare
tarekgh
approved these changes
Aug 6, 2025
|
/backport to release/9.0-staging |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/16782482600 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing: #117731, #117903