Skip to content

Protect against ODE when accessing configuration providers #117551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2025
Merged

Protect against ODE when accessing configuration providers #117551

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1274538
Protect against ODE when accessing configuration providers
tarekgh Jul 11, 2025
e0e4fdc
Update src/libraries/Microsoft.Extensions.Configuration/src/InternalC…
tarekgh Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/libraries/Microsoft.Extensions.Configuration/src/InternalConfigurationRootExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,20 @@ internal static bool TryGetConfiguration(this IConfigurationRoot root, string ke
for (int i = providers.Count - 1; i >= 0; i--)
{
IConfigurationProvider provider = providers[i];
if (provider.TryGet(key, out value))

try
{
if (provider.TryGet(key, out value))
{
return true;
}
}
catch (ObjectDisposedException)
{
return true;
// Skip disposed providers to avoid exceptions during access.
// This is especially relevant for cases like ConfigurationManager,
// which implements IConfigurationRoot and may mutate the providers
// collection and dispose replaced providers.
}
}

Expand Down
Loading