[NET] Fix calling non-validating ctor #117415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the unintended bypass of validation by removing the private non-validating constructor in IPNetwork and expands functional tests to verify parsed network properties.
- Removed the private non-validating
IPNetwork(IPAddress, int, bool)ctor and updated allTryParsecalls to use the public validating ctor. - Enhanced tests in
IPNetworkTest.csto compute and assertBaseAddress,PrefixLength, and normalizedToString()for both string and UTF-8 parsing.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/libraries/System.Net.Primitives/tests/FunctionalTests/IPNetworkTest.cs | Added computation of expected values and detailed assertions in Parse and TryParse tests. |
| src/libraries/System.Net.Primitives/src/System/Net/IPNetwork.cs | Removed the non-validating private ctor and updated TryParse to call the public ctor. |
src/libraries/System.Net.Primitives/tests/FunctionalTests/IPNetworkTest.cs
Outdated
Show resolved
Hide resolved
MihaZupan
approved these changes
Jul 8, 2025
This was referenced Jul 8, 2025
Open
|
/ba-g unrelated and/or known errors |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #117367, I have overlooked existence of "non-validating" ctor, thinking all ctor calls went through the one I've changed.
Thankfully @skyoxZ noticed it in #117367 (comment).
This fix addresses that and expands the tests to check the properties of parsed
IPNetwork.