Ensure hardware intrinsic tests are marked with [Fact] #117347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR marks several hardware intrinsic tests with the [Fact] attribute so they are discovered by xUnit.
- Added
using Xunit;to each test file - Prefixed test methods with
[Fact] - Changed test methods from
privatetopublic
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/tests/JIT/HardwareIntrinsics/X86/Sse2/ConvertToVector128Double.Double.cs | Added [Fact] and made method public |
| src/tests/JIT/HardwareIntrinsics/X86/Sse2/ConvertToUInt64.Vector128UInt64.cs | Added [Fact] and made method public |
| src/tests/JIT/HardwareIntrinsics/X86/Sse2/ConvertToInt64WithTruncation.Vector128Double.cs | Added [Fact] and made method public |
| src/tests/JIT/HardwareIntrinsics/X86/Sse2/ConvertToInt32WithTruncation.Int32.cs | Added [Fact] and made method public |
src/tests/JIT/HardwareIntrinsics/X86/Sse2/ConvertToVector128Double.Double.cs
Show resolved
Hide resolved
src/tests/JIT/HardwareIntrinsics/X86/Sse2/ConvertToUInt64.Vector128UInt64.cs
Show resolved
Hide resolved
src/tests/JIT/HardwareIntrinsics/X86/Sse2/ConvertToInt64WithTruncation.Vector128Double.cs
Show resolved
Hide resolved
src/tests/JIT/HardwareIntrinsics/X86/Sse2/ConvertToInt32WithTruncation.Int32.cs
Show resolved
Hide resolved
tannergooding
added
test-bug
|
CC. @dotnet/jit-contrib. Small test fix, just fixing a couple that weren't marked with |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
EgorBo
approved these changes
Jul 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #113231