Replace dangerous characters in response headers #117290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
MihaZupan
reviewed
Jul 3, 2025
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionBase.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/Headers/HeaderDescriptor.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 4, 2025
Open
antonfirsov
commented
Jul 7, 2025
src/libraries/System.Net.Http/src/System/Net/Http/Headers/HeaderDescriptor.cs
Show resolved
Hide resolved
MihaZupan
approved these changes
Jul 8, 2025
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116688
Edit: The original PR has been reworked.
The change has been optimized for the happy path, when no replacement has to be done. We are identifying it by scanning through undecoded
headerValuebytes, which is expected to be cheap E2E.Original description:
I ran a basic microbenchmark to see how much can this impact performance. The difference seems negligible on the happy path, especially with the
headerValue.IndexOfAny(s_dangerousCharacterBytes) >= 0optimization, though we can remove it if we prefer simplicity over a few nanosecs.