Fix -vs arg for ilc/crossgen #117268
Merged
Fix -vs arg for ilc/crossgen #117268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the -vs argument handling by allowing bare solution names and adds a fallback lookup for CMake-generated solutions in the AOT tools directory.
- Accept
coreclrandcorehost(without.sln) as valid-vsinputs - Add search path under
src\coreclr\tools\aotfor.slnxfiles
Comments suppressed due to low confidence (1)
eng/build.ps1:220
- The variable
$solutionis undefined here; it should likely use$vsinstead to correctly construct the path to the.slnxfile.
$vs = Split-Path $PSScriptRoot -Parent | Join-Path -ChildPath "src\coreclr\tools\aot" | Join-Path -ChildPath "$solution.slnx"
|
PTAL @MichalStrehovsky |
jkoritzinsky
approved these changes
Jul 3, 2025
This was referenced Jul 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
-vs ilcor-vs crossgenshould work (previously, these two require full path to be provided).Also, since all other solutions don't require file extension, I've removed it from coreclr and corehost as well.