Skip to content

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Jul 2, 2025

Reverts #116844

Copilot AI review requested due to automatic review settings July 2, 2025 07:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the previously added interpreter pipeline and associated flags, cleaning up test project settings and pipeline templates to remove runInterpreter support.

  • Removed RunInterpreter properties and Helix precommands from the Arcade test project
  • Updated Bash test targets to exclude arm64 from the existing launch path and added a dedicated arm64 block
  • Deleted the standalone interpreter pipeline YAML and removed references to runInterpreter in common pipeline templates

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/tests/Common/helixpublishwitharcade.proj Dropped _RunInterpreter property and corresponding Helix commands
src/tests/Common/CLRTest.Execute.Bash.targets Adjusted BashCLRTestLaunchCmds conditions; added arm64-specific block
eng/pipelines/coreclr/interpreter.yml Removed entire interpreter pipeline definition
eng/pipelines/common/templates/runtimes/send-to-helix-step.yml Removed runInterpreter parameter
eng/pipelines/common/templates/runtimes/run-test-job.yml Removed runInterpreter parameter
Comments suppressed due to low confidence (2)

src/tests/Common/CLRTest.Execute.Bash.targets:431

  • The URL‐encoded %3B should be a literal semicolon ;. Change ] %3B then to ]; then to ensure the if statement parses correctly in Bash.
if [ ! -z ${RunCrossGen2+x} ]%3B then

src/tests/Common/CLRTest.Execute.Bash.targets:435

  • The URL‐encoded %24 should be a literal dollar sign for command substitution. Replace %24(printf …) with $(printf …) so the arguments are formatted correctly.
echo $LAUNCHER $ExePath %24(printf "'%s' " "${CLRTestExecutionArguments[@]}")

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@jkotas jkotas requested review from eduardo-vp and mangod9 July 2, 2025 08:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants