-
Couldn't load subscription status.
- Fork 5.2k
Revert "Add interpreter pipeline" #117234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 359769e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts the previously added interpreter pipeline and associated flags, cleaning up test project settings and pipeline templates to remove runInterpreter support.
- Removed
RunInterpreterproperties and Helix precommands from the Arcade test project - Updated Bash test targets to exclude arm64 from the existing launch path and added a dedicated arm64 block
- Deleted the standalone interpreter pipeline YAML and removed references to
runInterpreterin common pipeline templates
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/tests/Common/helixpublishwitharcade.proj | Dropped _RunInterpreter property and corresponding Helix commands |
| src/tests/Common/CLRTest.Execute.Bash.targets | Adjusted BashCLRTestLaunchCmds conditions; added arm64-specific block |
| eng/pipelines/coreclr/interpreter.yml | Removed entire interpreter pipeline definition |
| eng/pipelines/common/templates/runtimes/send-to-helix-step.yml | Removed runInterpreter parameter |
| eng/pipelines/common/templates/runtimes/run-test-job.yml | Removed runInterpreter parameter |
Comments suppressed due to low confidence (2)
src/tests/Common/CLRTest.Execute.Bash.targets:431
- The URL‐encoded
%3Bshould be a literal semicolon;. Change] %3B thento]; thento ensure theifstatement parses correctly in Bash.
if [ ! -z ${RunCrossGen2+x} ]%3B then
src/tests/Common/CLRTest.Execute.Bash.targets:435
- The URL‐encoded
%24should be a literal dollar sign for command substitution. Replace%24(printf …)with$(printf …)so the arguments are formatted correctly.
echo $LAUNCHER $ExePath %24(printf "'%s' " "${CLRTestExecutionArguments[@]}")
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Reverts #116844