-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Include Pkcs (net10.0 & -windows) in aspnetcore transport pack #117173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures the System.Security.Cryptography.Pkcs assembly for the net10.0-windows TFM is included in the ASP.NET Core transport pack.
- Adds
System.Security.Cryptography.Pkcsto the shared framework props so it’s available in .NET 10. - References the Pkcs project with a windows-specific TFM and wires it into the transport pack MSBuild logic.
- Adjusts path separators in
packaging.targetsto flatten package and symbol output paths.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/NetCoreAppLibrary.props | Added System.Security.Cryptography.Pkcs to the list of included shared framework assemblies |
| src/libraries/Microsoft.Internal.Runtime.AspNetCore.Transport/src/Microsoft.Internal.Runtime.AspNetCore.Transport.proj | Added a windows-targeted Pkcs ProjectReference and a custom target to surface it |
| eng/packaging.targets | Switched to forward slashes and removed redundant separators in package/symbol paths |
Comments suppressed due to low confidence (3)
src/libraries/Microsoft.Internal.Runtime.AspNetCore.Transport/src/Microsoft.Internal.Runtime.AspNetCore.Transport.proj:40
- Consider adding an integration or packaging test to verify that the Pkcs DLL and its PDB actually end up in the
runtimes/win/lib/$(NetCoreAppCurrent)folder of the generated ASP.NET Core transport package.
<ProjectReference Include="$(LibrariesProjectRoot)System.Security.Cryptography.Pkcs\src\System.Security.Cryptography.Pkcs.csproj"
eng/packaging.targets:253
- Mixing forward slashes and backslashes in MSBuild paths can lead to inconsistent output on Windows. Consider using
$(BuildOutputTargetFolder)\$(_referringTargetFramework)\or normalizing separators uniformly.
PackagePath="$([MSBuild]::ValueOrDefault('%(ReferenceCopyLocalPaths.PackagePath)', '$(BuildOutputTargetFolder)/$(_referringTargetFramework)/'))" />
eng/packaging.targets:255
- This relies on
PackagePathending with a slash. If it doesn't, output paths may run together. You might add a slash in the metadata or useTrimEnd('\/')and then append a single separator.
TargetPath="/%(TfmSpecificPackageFile.PackagePath)%(Filename)%(Extension)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/ba-g failures are unrelated |
Fixes #117146