Skip to content

cleanup memory after UnflushedBytes_HandlesLargeValues test #117115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025
Merged

cleanup memory after UnflushedBytes_HandlesLargeValues test #117115

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5eab0e
cleanup memory after UnflushedBytes_HandlesLargeValues test
pedrobsaila Jun 28, 2025
e6ec6ce
Update src/libraries/System.IO.Pipelines/tests/PipeWriterTests.cs
pedrobsaila Jun 30, 2025
8a0280c
use memory pool that manages single buffer and reuse it each time a b…
pedrobsaila Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions src/libraries/System.IO.Pipelines/tests/PipeWriterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,19 +361,30 @@ public async Task GetMemoryFlushWithACompletedReaderNoops()
Assert.Equal(0, Pipe.Writer.UnflushedBytes);
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotBrowser), nameof(PlatformDetection.Is64BitProcess))]
public void UnflushedBytes_HandlesLargeValues()
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMobile), nameof(PlatformDetection.Is64BitProcess))]
[OuterLoop]
public async Task UnflushedBytes_HandlesLargeValues()
{
PipeWriter writer = PipeWriter.Create(Stream.Null);
int bufferSize = 10000;

while (writer.UnflushedBytes >= 0 && writer.UnflushedBytes <= int.MaxValue)
try
{
writer.GetMemory(bufferSize);
writer.Advance(bufferSize);
}
int bufferSize = 10000;

while (writer.UnflushedBytes >= 0 && writer.UnflushedBytes <= int.MaxValue)
{
writer.GetMemory(bufferSize);
writer.Advance(bufferSize);
}

Assert.Equal(2147490000, writer.UnflushedBytes);
Assert.Equal(2147490000, writer.UnflushedBytes);
}
finally
{
await writer.FlushAsync();
await writer.CompleteAsync();
GC.Collect(2, GCCollectionMode.Forced, true, true);
}
}
}
}
Loading