Skip to content

Check containment for op3 for ternary instruction #116229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

Check containment for op3 for ternary instruction #116229

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
557e82a
Check containment for op3 for ternary instruction
kunalspathak Jun 2, 2025
8c7a19c
review comment
kunalspathak Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/coreclr/jit/lsraxarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2965,8 +2965,18 @@ int LinearScan::BuildHWIntrinsic(GenTreeHWIntrinsic* intrinsicTree, int* pDstCou
}
#endif // TARGET_AMD64

srcCount += isRMW ? BuildDelayFreeUses(op3, op1, op3RegCandidates)
: BuildOperandUses(op3, op3RegCandidates);
if (op3->OperIs(GT_HWINTRINSIC) && op3->AsHWIntrinsic()->OperIsMemoryLoad() && op3->isContained())
{
srcCount += BuildAddrUses(op3->AsHWIntrinsic()->Op(1), op3RegCandidates);
Comment on lines +2968 to +2970
Copy link

Copilot AI Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider caching the result of op3->AsHWIntrinsic() in a local variable to improve readability and potentially reduce redundant method calls. For example, store the cast result in a variable and then reuse it within the conditional block.

Suggested change
if (op3->OperIs(GT_HWINTRINSIC) && op3->AsHWIntrinsic()->OperIsMemoryLoad() && op3->isContained())
{
srcCount += BuildAddrUses(op3->AsHWIntrinsic()->Op(1), op3RegCandidates);
auto op3HWIntrinsic = op3->AsHWIntrinsic();
if (op3->OperIs(GT_HWINTRINSIC) && op3HWIntrinsic->OperIsMemoryLoad() && op3->isContained())
{
srcCount += BuildAddrUses(op3HWIntrinsic->Op(1), op3RegCandidates);

Copilot uses AI. Check for mistakes.
}
else if (isRMW)
{
srcCount += BuildDelayFreeUses(op3, op1, op3RegCandidates);
}
else
{
srcCount += BuildOperandUses(op3, op3RegCandidates);
}

if (op4 != nullptr)
{
Expand Down
Loading