Skip to content

arm64: Rename ConditionalExtract arguments #116216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 10, 2025
Merged

arm64: Rename ConditionalExtract arguments #116216

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
19d31e6
arm64: Rename ConditionalExtract arguments
jonathandavies-arm Jun 2, 2025
792e71b
Add Compatibility Suppression
jonathandavies-arm Jun 4, 2025
f62a15a
Merge branch 'main' into upstream/sve/cobalt/rename-conditional-extract
jonathandavies-arm Jun 4, 2025
86d79de
Fix the compatibility issues
kunalspathak Jun 10, 2025
4465b3e
Fix the names in ref file
kunalspathak Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
172 changes: 158 additions & 14 deletions src/coreclr/nativeaot/System.Private.CoreLib/src/CompatibilitySuppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids -->
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<Suppression>
Copy link
Contributor

@kunalspathak kunalspathak Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, updating the file under nativeaot feels little odd too.

<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Internal.Console</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Internal.Metadata.NativeFormat.ArraySignature</Target>
Expand Down Expand Up @@ -53,14 +57,6 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Internal.Metadata.NativeFormat.ConstantBooleanValueHandle</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Internal.Metadata.NativeFormat.ConstantEnumValue</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Internal.Metadata.NativeFormat.ConstantEnumValueHandle</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Internal.Metadata.NativeFormat.ConstantByteArray</Target>
Expand Down Expand Up @@ -117,6 +113,14 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Internal.Metadata.NativeFormat.ConstantEnumArrayHandle</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Internal.Metadata.NativeFormat.ConstantEnumValue</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Internal.Metadata.NativeFormat.ConstantEnumValueHandle</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Internal.Metadata.NativeFormat.ConstantHandleArray</Target>
Expand Down Expand Up @@ -725,6 +729,10 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Internal.TypeSystem.LockFreeReaderHashtable`2</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Internal.TypeSystem.LockFreeReaderHashtableOfPointers`2</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Diagnostics.DebugAnnotations</Target>
Expand All @@ -735,11 +743,11 @@
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.MDArray</Target>
<Target>T:System.FieldHandleInfo</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.FieldHandleInfo</Target>
<Target>T:System.MDArray</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
Expand Down Expand Up @@ -810,19 +818,155 @@
<Target>T:System.Runtime.CompilerServices.StaticClassConstructionContext</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Internal.TypeSystem.LockFreeReaderHashtableOfPointers`2</Target>
<DiagnosticId>CP0002</DiagnosticId>
<Target>F:System.Resources.ResourceManager.BaseNameField</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>F:System.Resources.ResourceSet.Reader</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:System.Diagnostics.DiagnosticMethodInfo.#ctor(System.String,System.String,System.String)</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:System.Reflection.MethodBase.GetParametersAsSpan</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:System.Threading.Lock.#ctor(System.Boolean)</Target>
<Target>M:System.String.Trim(System.ReadOnlySpan{System.Char})</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:System.Diagnostics.DiagnosticMethodInfo.#ctor(System.String,System.String,System.String)</Target>
<Target>M:System.String.TrimEnd(System.ReadOnlySpan{System.Char})</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:System.String.TrimStart(System.ReadOnlySpan{System.Char})</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:System.Threading.Lock.#ctor(System.Boolean)</Target>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElement(System.Numerics.Vector{System.Byte},System.Byte,System.Numerics.Vector{System.Byte})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElement(System.Numerics.Vector{System.Double},System.Double,System.Numerics.Vector{System.Double})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElement(System.Numerics.Vector{System.Int16},System.Int16,System.Numerics.Vector{System.Int16})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElement(System.Numerics.Vector{System.Int32},System.Int32,System.Numerics.Vector{System.Int32})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElement(System.Numerics.Vector{System.Int64},System.Int64,System.Numerics.Vector{System.Int64})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElement(System.Numerics.Vector{System.SByte},System.SByte,System.Numerics.Vector{System.SByte})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElement(System.Numerics.Vector{System.Single},System.Single,System.Numerics.Vector{System.Single})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElement(System.Numerics.Vector{System.UInt16},System.UInt16,System.Numerics.Vector{System.UInt16})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElement(System.Numerics.Vector{System.UInt32},System.UInt32,System.Numerics.Vector{System.UInt32})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElement(System.Numerics.Vector{System.UInt64},System.UInt64,System.Numerics.Vector{System.UInt64})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElementAndReplicate(System.Numerics.Vector{System.Byte},System.Numerics.Vector{System.Byte},System.Numerics.Vector{System.Byte})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElementAndReplicate(System.Numerics.Vector{System.Double},System.Numerics.Vector{System.Double},System.Numerics.Vector{System.Double})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElementAndReplicate(System.Numerics.Vector{System.Int16},System.Numerics.Vector{System.Int16},System.Numerics.Vector{System.Int16})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElementAndReplicate(System.Numerics.Vector{System.Int32},System.Numerics.Vector{System.Int32},System.Numerics.Vector{System.Int32})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElementAndReplicate(System.Numerics.Vector{System.Int64},System.Numerics.Vector{System.Int64},System.Numerics.Vector{System.Int64})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElementAndReplicate(System.Numerics.Vector{System.SByte},System.Numerics.Vector{System.SByte},System.Numerics.Vector{System.SByte})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElementAndReplicate(System.Numerics.Vector{System.Single},System.Numerics.Vector{System.Single},System.Numerics.Vector{System.Single})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElementAndReplicate(System.Numerics.Vector{System.UInt16},System.Numerics.Vector{System.UInt16},System.Numerics.Vector{System.UInt16})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElementAndReplicate(System.Numerics.Vector{System.UInt32},System.Numerics.Vector{System.UInt32},System.Numerics.Vector{System.UInt32})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
<Suppression>
<DiagnosticId>CP0017</DiagnosticId>
<Target>M:System.Runtime.Intrinsics.Arm.Sve.ConditionalExtractLastActiveElementAndReplicate(System.Numerics.Vector{System.UInt64},System.Numerics.Vector{System.UInt64},System.Numerics.Vector{System.UInt64})$1</Target>
<Left>ref/net10.0/System.Private.CoreLib.dll</Left>
<Right>lib/net10.0/System.Private.CoreLib.dll</Right>
</Suppression>
</Suppressions>
Loading
Loading