[release/9.0-staging] Fix generation of minidump (#115562) #116053
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses a minidump generation issue by wrapping IL version method calls with a try-catch block to ensure that an exception in GetIL doesn’t prevent dumping a full callstack. Wraps GetIL and related ILCodeVersion calls in an exception block Uses EX_CATCH_RETHROW_ONLY_COR_E_OPERATIONCANCELLED to selectively rethrow only specific exceptions
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with minidump generation by adding a nested try/catch block around IL version method calls to ensure that exceptions from GetIL do not abort memory enumeration.
- Adds a try block wrapping ilVersion method calls
- Introduces a catch that rethrows only OperationCancelled exceptions to preserve full dump generation
| ilVersion.GetVersionId(); | ||
| ilVersion.GetRejitState(); | ||
| ilVersion.GetIL(); | ||
| EX_TRY |
There was a problem hiding this comment.
Consider adding an inline comment within the try/catch block to explain why only OperationCancelled exceptions are rethrown. This will help future maintainers understand the specific exception handling strategy.
|
Closing as a dupe to #115738 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #115562
Customer Impact
Addresses a customer reported issue in minidump generation. The DAC implements
ICLRDataEnumMemoryRegions::EnumMemoryRegionswhich is used bydbghelp!MiniDumpWriteDumpto mark pages in the process that must be saved for actionable dumps. As some memory enumeration API's might fail at dump collection time, we implement try/catch blocks around the logic that collects memory pages so that the entire process is not aborted. We have a customer report on an issue resulting in corrupted mini-dumps, missing memory needed for stackwalking. The issue was narrowed down to a call toGetILon anInlinedCallFramecauses an exception to be thrown during memory enumeration, resulting in skipping over other memory collection API's that would have succeeded and in turn creating a minidump missing memory needed for stackwalking. The fix addresses the issue by wrapping the IL version method calls at a lower-level with a nested try-catch block to ensure that an exception inGetILdoesn’t prevent dumping a full callstack.Regression
Testing
Manually tested, the customer verified
Risk
Low risk, we are adding a more granular try/catch around dump generation code