EE - Fix deadlock on thread suspension by GC collection (#115794) #115892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
filipnavara
added
area-GC-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/gc |
mangod9
reviewed
May 22, 2025
| // To mitigate this issue, when the next link points to itself, de-reference the next link | ||
| // TODO : find which code is responsible for allowing the situation to happen | ||
| if ( psb->m_Link.m_pNext == pLink->m_pNext) | ||
| pLink->m_pNext = NULL; |
There was a problem hiding this comment.
Let's try to investigate the root cause instead of taking this fix as-is since there could be other issues/AVs related to the mangling of the list.
This was referenced May 22, 2025
Open
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by mitigating the circularity formed in a singly linked list, which is iterated by the EE for suspension when GC is triggered
The issue causes the application to deadlock indefinitely, this PR releases the deadlock
Fix #115794