Skip to content

Fix the incorrect code comment in DetermineCreateObjectDelegate #115038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Fix the incorrect code comment in DetermineCreateObjectDelegate #115038

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e8a23e
Fix the incorrect code comment in DetermineCreateObjectDelegate
Silencersn Apr 25, 2025
d5549ba
Merge branch 'main' into fix-comment
eiriktsarpalis Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...t.Json/src/System/Text/Json/Serialization/Metadata/DefaultJsonTypeInfoResolver.Helpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ internal static void DeterminePropertyAccessors<T>(JsonPropertyInfo<T> jsonPrope
if (converter.ConstructorInfo != null && !converter.ConstructorIsParameterized)
{
// A parameterless constructor has been resolved by the converter
// (e.g. it might be a non-public ctor with JsonConverterAttribute).
// (e.g. it might be a non-public ctor with JsonConstructorAttribute).
defaultCtor = converter.ConstructorInfo;
}

Expand Down
Loading