[release/10.0-preview4] Rewrite of System.Numerics.Tensors to allow for more code sharing, various correctness fixes, and stability improvements #114979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…qual, and the *All/*Any variants
* Refactor Tensor to be more reusable and validate appropriate state * finishing tensor primitives work --------- Co-authored-by: Tanner Gooding <[email protected]>
* only couple left * pausing for food * fixed rented buffer * squeeze/unsqueeze * set slice/ split * only 2 left
…1, so embedded broadcasting works
* Fixing Broadcasting Loop * fixes from pr coments * squeeze fixed * unsqueeze * set slice * more tensor fies
* stack working * more tensor tests working * fix factory create tests
…ors/netcore/TensorShape.cs
ghost
added
|
Note regarding the |
1 similar comment
|
Note regarding the |
|
Tagging subscribers to this area: @dotnet/area-system-numerics-tensors |
This was referenced Apr 24, 2025
|
Ping me when it's approved by Tactics and ready to merge. |
ericstj
approved these changes
Apr 24, 2025
|
/ba-g Failures are known and unrelated, one of them being: #115018 |
carlossanlop
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #114927 to release/10.0-preview4
/cc @tannergooding
Customer Impact
This backports the rewrite of System.Numerics.Tensors so that it can be included in .NET 10 Preview 4, which is a key preview to get the changes in front of the community.
The rewrite was done in order to fix a number of issues and edge cases found in the initial .NET 9 preview of System.Numerics.Tensors, namely in ensuring that we have consistent and correct handling for tensors of all shapes.
Regression
This was a preview API in .NET 9.
Testing
Tests were updated to match the expected functionality, additional debug assertions were added to validate correctness, and explanatory comments were added in many locations to help explain both "how" the complex logic works and "why" certain things behave the way they do.
There is still more tests to be added, but they will go into main and are not necessary for the updated preview of System.Numerics.Tensors
Risk
Low. This was purely a preview API and exists "out of band" compared to other library APIs. That is, it requires users to explicitly add a NuGet package reference to get access to these APIs.