Skip to content

Do not rethrow from SocketsTestServerAPM.OnAccept #114964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2025
Merged

Do not rethrow from SocketsTestServerAPM.OnAccept #114964

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ebdf53
Do not rethrow from SocketTestServerAPM.OnAccept
rzikm Apr 23, 2025
49f3b85
Update src/libraries/Common/tests/System/Net/Sockets/SocketTestServer…
rzikm Apr 23, 2025
95ef007
Update src/libraries/Common/tests/System/Net/Sockets/SocketTestServer…
rzikm Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,9 @@
{
client = _socket.EndAccept(result);
}
catch (SocketException e)
catch (SocketException)
{
if (_disposed ||
e.SocketErrorCode == SocketError.OperationAborted ||
e.SocketErrorCode == SocketError.Interrupted)
{
return;
}

throw;
return;
}
catch (ObjectDisposedException)
{
Expand All @@ -81,16 +74,8 @@
{
_socket.BeginAccept(OnAccept, null);
}
catch (SocketException e)

Check failure on line 77 in src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug Mono_Interpreter_LibrariesTests)

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs#L77 

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs(77,36): error CS0168: (NETCORE_ENGINEERING_TELEMETRY=Build) The variable 'e' is declared but never used

Check failure on line 77 in src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs#L77 

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs(77,36): error CS0168: (NETCORE_ENGINEERING_TELEMETRY=Build) The variable 'e' is declared but never used

Check failure on line 77 in src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs#L77 

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs(77,36): error CS0168: (NETCORE_ENGINEERING_TELEMETRY=Build) The variable 'e' is declared but never used

Check failure on line 77 in src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-x64 Debug CoreCLR_Libraries)

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs#L77 

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs(77,36): error CS0168: (NETCORE_ENGINEERING_TELEMETRY=Build) The variable 'e' is declared but never used

Check failure on line 77 in src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug CoreCLR_Libraries)

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs#L77 

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs(77,36): error CS0168: (NETCORE_ENGINEERING_TELEMETRY=Build) The variable 'e' is declared but never used

Check failure on line 77 in src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug Libraries_CheckedCoreCLR)

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs#L77 

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs(77,36): error CS0168: (NETCORE_ENGINEERING_TELEMETRY=Build) The variable 'e' is declared but never used

Check failure on line 77 in src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests)

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs#L77 

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs(77,36): error CS0168: (NETCORE_ENGINEERING_TELEMETRY=Build) The variable 'e' is declared but never used

Check failure on line 77 in src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs#L77 

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs(77,36): error CS0168: (NETCORE_ENGINEERING_TELEMETRY=Build) The variable 'e' is declared but never used

Check failure on line 77 in src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_EAT)

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs#L77 

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs(77,36): error CS0168: (NETCORE_ENGINEERING_TELEMETRY=Build) The variable 'e' is declared but never used

Check failure on line 77 in src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Libraries_CheckedCoreCLR)

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs#L77 

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs(77,36): error CS0168: (NETCORE_ENGINEERING_TELEMETRY=Build) The variable 'e' is declared but never used

Check failure on line 77 in src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug CoreCLR_Libraries)

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs#L77 

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs(77,36): error CS0168: (NETCORE_ENGINEERING_TELEMETRY=Build) The variable 'e' is declared but never used

Check failure on line 77 in src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs

View check run for this annotation

Azure Pipelines / runtime

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs#L77 

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs(77,36): error CS0168: (NETCORE_ENGINEERING_TELEMETRY=Build) The variable 'e' is declared but never used

Check failure on line 77 in src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs

View check run for this annotation

Azure Pipelines / runtime

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs#L77 

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs(77,36): error CS0168: (NETCORE_ENGINEERING_TELEMETRY=Build) The variable 'e' is declared but never used

Check failure on line 77 in src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs

View check run for this annotation

Azure Pipelines / runtime

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs#L77 

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs(77,36): error CS0168: (NETCORE_ENGINEERING_TELEMETRY=Build) The variable 'e' is declared but never used

Check failure on line 77 in src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs

View check run for this annotation

Azure Pipelines / runtime

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs#L77 

src/libraries/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs(77,36): error CS0168: (NETCORE_ENGINEERING_TELEMETRY=Build) The variable 'e' is declared but never used
{
if (_disposed ||
e.SocketErrorCode == SocketError.OperationAborted ||
e.SocketErrorCode == SocketError.Interrupted)
{
return;
}

throw;
}
catch (ObjectDisposedException)
{
Expand Down
Loading