[wasm][interp] Fix PackedSimd.Splat intrinsic lookup #114413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
lewing
requested review from
BrzVlad,
kotlarmilos,
steveisok and
vitek-karas
as code owners
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/mono/mono/mini/interp/transform-simd.c:995
- The new condition using MONO_TYPE_IS_VECTOR_PRIMITIVE may lead to overmatching, potentially accepting unintended argument types. Consider refining the check to more precisely target the intended scalar argument types.
} else if (MONO_TYPE_IS_VECTOR_PRIMITIVE(arg1)) {
|
It looks good. |
steveisok
approved these changes
Apr 9, 2025
This was referenced Apr 9, 2025
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause of #114401 was actually that the lookup was rejecting the single scalar arg. There is a non-zero chance this fix will cause some overmatching.
fixes
#114401