Skip to content

[wasm][interp] Match more Vector intrinsics to PackedSimd intrinsics #114070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 1, 2025
Merged

[wasm][interp] Match more Vector intrinsics to PackedSimd intrinsics #114070

merged 5 commits into from
Apr 1, 2025

Conversation

@lewing
Copy link
Member

@lewing lewing commented Mar 31, 2025 •
edited
Loading

Follow-up to #113743 that adds some missing methods.

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

This was referenced Mar 31, 2025
Closed
Open
@kg kg mentioned this pull request Apr 3, 2025
Closed
This was referenced Mar 31, 2025
Open
Closed
@lewing lewing marked this pull request as ready for review March 31, 2025 21:41
@Copilot Copilot AI review requested due to automatic review settings March 31, 2025 21:41
Copilot
Copilot AI reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • src/mono/mono/mini/interp/simd-methods.def: Language not supported
  • src/mono/mono/mini/interp/transform-simd.c: Language not supported

@lewing lewing requested a review from radekdoulik March 31, 2025 21:41
@build-analysis build-analysis bot mentioned this pull request Apr 1, 2025
Closed
@lewing
Copy link
Member Author

lewing commented Apr 1, 2025

/ba-g failures are known

@lewing lewing force-pushed the wasm-more-intrin branch from fc43a3b to 105ecdd Compare April 1, 2025 17:59
@lewing lewing changed the title [wasm][interp] Try out a few more matches for the intrinsics [wasm][interp] Matches more Vector intrinsics to PackedSimd intrinsics Apr 1, 2025
@lewing lewing changed the title [wasm][interp] Matches more Vector intrinsics to PackedSimd intrinsics [wasm][interp] Match more Vector intrinsics to PackedSimd intrinsics Apr 1, 2025
radekdoulik
radekdoulik approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@radekdoulik radekdoulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lewing
Copy link
Member Author

lewing commented Apr 1, 2025

/ba-g failures are known

@lewing lewing merged commit 11de52a into dotnet:main Apr 1, 2025
66 of 71 checks passed
@lewing lewing deleted the wasm-more-intrin branch April 1, 2025 21:00
This was referenced Apr 3, 2025
Open
Closed
Open
Closed
Closed
Closed
@lewing lewing mentioned this pull request Apr 10, 2025
Open
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@radekdoulik radekdoulik radekdoulik approved these changes

@BrzVlad BrzVlad Awaiting requested review from BrzVlad BrzVlad is a code owner

@kotlarmilos kotlarmilos Awaiting requested review from kotlarmilos kotlarmilos is a code owner

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas is a code owner

Assignees

@lewing lewing

Labels

area-Codegen-Interpreter-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lewing @radekdoulik