JIT: more anticipatory extra SPMI queries for array stack alloc #111441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Augment the set of extra queries added in dotnet#111293 with a few more that we might call when stack allocating arrays.
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
PTAL @dotnet/jit-contrib I can work around the lack of embedded handle info, but not some of the others. |
BruceForstall
approved these changes
Jan 14, 2025
Member
|
FWIW, one thing you can do is just run superpmi-collect on a custom JIT build when wanting to do stuff like this. Typically just running the collection on the actual PR works (but of course in some cases that might result in misses in the baseline, although I've never really had ran into that issue to any noticeable extent). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment the set of extra queries added in #111293 with a few more that we might call when stack allocating arrays.