Make longjmp over managed frames work #111259
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| project (Test11242Lib) | ||
janvorli marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| include_directories(${INC_PLATFORM_DIR}) | ||
|
|
||
| if(CLR_CMAKE_HOST_WIN32) | ||
| set_source_files_properties(Test11242.c PROPERTIES COMPILE_OPTIONS /TC) # compile as C | ||
| else() | ||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fvisibility=hidden") | ||
| set(CMAKE_CPP_FLAGS "${CMAKE_CPP_FLAGS} -fvisibility=hidden -Wno-return-type-c-linkage") | ||
| endif() | ||
|
|
||
| # add the executable | ||
| add_library (Test11242Lib SHARED Test11242.c) | ||
|
|
||
| # add the install targets | ||
| install (TARGETS Test11242Lib DESTINATION bin) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // Copyright (c) Microsoft. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| #include <stdint.h> | ||
| #include <stdio.h> | ||
| #include <setjmp.h> | ||
|
|
||
|
|
||
| #ifdef _MSC_VER | ||
| #define DLLEXPORT __declspec(dllexport) | ||
| #else | ||
| #define DLLEXPORT __attribute__((visibility("default"))) | ||
| #endif // _MSC_VER | ||
|
|
||
| DLLEXPORT void TestSetJmp(void (*managedCallback)(void *)) | ||
| { | ||
| jmp_buf jmpBuf; | ||
| if (!setjmp(jmpBuf)) | ||
| { | ||
| managedCallback(&jmpBuf); | ||
| } | ||
| else | ||
| { | ||
| printf("longjmp called\n"); | ||
| } | ||
| } | ||
|
|
||
| DLLEXPORT void TestLongJmp(void *jmpBuf) | ||
| { | ||
| longjmp(*(jmp_buf*)jmpBuf, 1); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using System.Runtime.InteropServices; | ||
| using System.Runtime.CompilerServices; | ||
| using Xunit; | ||
|
|
||
| public static class Test11242 | ||
| { | ||
| [DllImport("Test11242Lib")] | ||
| static extern unsafe void TestSetJmp(delegate* unmanaged<void*,void> managedCallback); | ||
|
|
||
| [DllImport("Test11242Lib")] | ||
| static extern unsafe void TestLongJmp(void *jmpBuf); | ||
|
|
||
| static bool ExceptionFilter(Exception ex) | ||
| { | ||
| Assert.Fail("Should not call filter for longjmp SEH exception"); | ||
| return true; | ||
| } | ||
|
|
||
| static bool wasFinallyInvoked = false; | ||
|
|
||
| [UnmanagedCallersOnly] | ||
| static unsafe void ManagedCallback(void *jmpBuf) | ||
| { | ||
| try | ||
| { | ||
| TestLongJmp(jmpBuf); | ||
| } | ||
| catch (Exception ex) when (ExceptionFilter(ex)) | ||
| { | ||
| Assert.Fail("Should not catch longjmp SEH exception via filter"); | ||
| } | ||
| catch | ||
| { | ||
| Assert.Fail("Should not catch longjmp SEH exception via filter"); | ||
| } | ||
| finally | ||
| { | ||
| Console.WriteLine("Finally block executed"); | ||
| wasFinallyInvoked = true; | ||
| } | ||
| Assert.Fail("Should not reach here"); | ||
| } | ||
|
|
||
| [Fact] | ||
| public static unsafe void TestEntryPoint() | ||
| { | ||
| TestSetJmp(&ManagedCallback); | ||
| Assert.True(wasFinallyInvoked); | ||
| Console.WriteLine("Test passed"); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <!-- Needed for CMakeProjectReference --> | ||
| <RequiresProcessIsolation>true</RequiresProcessIsolation> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <CLRTestPriority>1</CLRTestPriority> | ||
| <CLRTestTargetUnsupported Condition="'$(TargetOS)' != 'windows'">true</CLRTestTargetUnsupported> | ||
| </PropertyGroup> | ||
| <PropertyGroup> | ||
| <DebugType>PdbOnly</DebugType> | ||
| <Optimize>True</Optimize> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Compile Include="Test11242.cs" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <CMakeProjectReference Include="CMakeLists.txt" /> | ||
| </ItemGroup> | ||
| </Project> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to unwind Frames to avoid corrupting runtime data structures?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And if we are unwinding Frames, is it that hard to call finallys too to match the old behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had it implemented by propagating the exception through the managed frames as usual, so the finallys were called, and then re-issued the longjmp after processing them. The only missing part to do was preventing calling catch handlers. The old EH doesn't call those "naturally", as the longjmp runs only the unwind pass.
And then you've mentioned it was not supported, so I have deleted that code :-).
But anyways, I can change it back to that, the change wasn't complicated. The only thing is that the Unix handling would then be different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
longjump over managed code does not and cannot work well on Unix, so I do not think it is a problem