Fold "X relop 0" in assertprop #110076
Merged
Fold "X relop 0" in assertprop #110076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
PTAL @jakobbotsch @dotnet/jit-contrib Diffs I'll look into making it more advanced |
jakobbotsch
reviewed
Nov 22, 2024
jakobbotsch
approved these changes
Nov 22, 2024
This was referenced Nov 25, 2024
EgorBo
pushed a commit
that referenced
this pull request
Nov 25, 2024
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
* Revert "Fold "X relop 0" in assertprop (dotnet#110076)" This reverts commit b5bdce2. * Dummy edit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
optAssertionProp_RangePropertiesto fold various "X relop 0" patterns in global assertion prop.This, technically, repeats what RBO does, but with help of assertions. There should be more diffs if we generalize it.