Skip to content

Conversation

@AndyAyersMS
Copy link
Member

@AndyAyersMS AndyAyersMS commented Oct 26, 2024

Contributes to #108913

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 26, 2024
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS
Copy link
Member Author

@MihuBot

@AndyAyersMS
Copy link
Member Author

@EgorBo FYI -- this seems to just work now (perhaps because of the work you did on inlining shared generics). Not surprisingly it leads to size increases, but the diffs don't look too bad.

@AndyAyersMS
Copy link
Member Author

SPMI won't show the impact of this, since the JIT will be making new interface calls.

@AndyAyersMS AndyAyersMS marked this pull request as ready for review October 26, 2024 17:47
@AndyAyersMS
Copy link
Member Author

@EgorBo PTAL
cc @dotnet/jit-contrib

@AndyAyersMS AndyAyersMS requested a review from EgorBo October 27, 2024 00:07
@EgorBo
Copy link
Member

EgorBo commented Oct 27, 2024

@EgorBo FYI -- this seems to just work now (perhaps because of the work you did on inlining shared generics). Not surprisingly it leads to size increases, but the diffs don't look too bad.

Right, it explains why we still have to keep CORINFO_FIELD_STATIC_READYTORUN_HELPER, there were NAOT/R2R cases we couldn't inline them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants