Rename WasmBuildTests settings to the names of properties they impact
#108780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2024
Open
maraf
reviewed
Oct 11, 2024
maraf
reviewed
Oct 14, 2024
pavelsavara
approved these changes
Oct 14, 2024
This was referenced Oct 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It avoids confusion when running tests manually. Setting
WasmEnableWebcilwill propagate the value toWasmEnableWebciletc. We leftTestUsingWorkloadsbecause it just chooses if we will usedotnet-latestordotnet-none, so no value propagation involved.