Skip to content

Conversation

@alhad-deshpande
Copy link
Contributor

This PR fixes assertion failure mentioned in PR 107678.

alhad-deshpande and others added 30 commits September 8, 2022 10:55
…ystem.Runtime.Serialization.Formatters tests
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 1, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 1, 2024
@alhad-deshpande
Copy link
Contributor Author

@akoeplinger
This PR fixes assertion failure mentioned in PR #107678 (comment). Can you please approve/merge this PR?

@alhad-deshpande
Copy link
Contributor Author

@lambdageek
Can you please approve/merge this PR?

@akoeplinger
Copy link
Member

/azp run runtime-community

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger
Copy link
Member

sorry for the late response, I was on vacation and am still catching up on GitHub notifications 😄

@akoeplinger
Copy link
Member

/azp run runtime-community

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alhad-deshpande
Copy link
Contributor Author

sorry for the late response, I was on vacation and am still catching up on GitHub notifications 😄

No problem. Thanks for approving!

@alhad-deshpande
Copy link
Contributor Author

@akoeplinger
The build failed due to new vulnerability warning https://dev.azure.com/dnceng-public/public/_build/results?buildId=835423&view=results.

I have merged latest main and the build should pass now.
Can you please rerun CLI?

@akoeplinger
Copy link
Member

/azp run runtime-community

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger
Copy link
Member

/ba-g this only changes ppc64le codepaths so the other failures are unrelated

@akoeplinger akoeplinger merged commit 6fad376 into dotnet:main Oct 9, 2024
116 of 124 checks passed
rzikm pushed a commit to rzikm/dotnet-runtime that referenced this pull request Oct 11, 2024
…ystem.Runtime.Serialization.Formatters tests (dotnet#108429)

* [ppc64le] Fixed thunk address 8 byte alignment issue

* Fixed FSharp crash issue

* [ppc64le] Implementation of mono_arch_get_delegate_virtual_invoke_impl method for ppc64le architecture

* Fixed clang15 build issues and returning address of sc_sp instead of value

* Added float32 support and implemented related opcodes

* Correction in OP_RCONV_TO_R cases

* Corrected code for few opcodes

* [ppc64le] performance improvements while branching

* [ppc64le] Fixed insufficient memory exception issue

* [ppc64le] Fixed assertion failure which was occurring while running System.Runtime.Serialization.Formatters tests
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants