[release/9.0][browser] Enable the log profiler #107747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
Servicing-approved
pavelsavara
requested review from
BrzVlad,
akoeplinger,
lambdageek,
lewing,
maraf,
marek-safar and
steveisok
as code owners
4 tasks
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing |
Member
Author
|
servicing approved here #107626 (comment) |
lewing
approved these changes
Sep 12, 2024
jeffschwMSFT
approved these changes
Sep 12, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we can merge when ready
Member
|
@pavelsavara please take a look at the failing PR legs. |
Member
|
The failure in WasmBuildTests is #106160 |
Member
Author
It's unrelated known issue #106160 |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107434 to release/9.0
Customer Impact
Enables Uno to use legacy memory profiler, which they already use with custom build of the runtime in Net8.
We don't have EventPipe solution for browser yet.
Regression
Testing
Automated test on main branch
Risk
Low. This is only used when
<WasmProfilers>log;</WasmProfilers><WasmBuildNative>true</WasmBuildNative>