[release/9.0] Fix EVP_MAC_CTX cleanup in one shot #107471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
bartonjs
approved these changes
Sep 6, 2024
bartonjs
added
Servicing-consider
jeffhandley
approved these changes
Sep 9, 2024
Member
|
@artl93 - This flowed through Tactics last week and was approved. Please review and merge when ready. |
artl93
approved these changes
Sep 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107431 to release/9.0
/cc @vcsjones
Customer Impact
The one-shot implementation of KMAC had a native memory leak, an EVP_MAC_CTX. Customers using the static
HashDataonKmac128,KmacXof128, or their 256-bit counterparts, will see a slow increase in memory that will never be freed.Regression
This functionality is new in .NET 9.0.
Testing
The existing tests verify that it works as expected. Manually verified that unbound memory growth is no longer observed.
Risk
Low. Adds a missing
EVP_MAC_CTX_freeto all code paths.