Skip to content

Build NativeAOT-iOS runtime tests as standalone to restore test runs #107366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Build NativeAOT-iOS runtime tests as standalone to restore test runs #107366

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4e2880
Build NativeAOT-iOS runtime tests as standalone to restore test runs
jkoritzinsky Sep 4, 2024
0202b0a
Fix catalyst as well
jkoritzinsky Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ parameters:
variables: {}
pool: ''
dependsOn: []
compileOnHelix: false
interpreter: false
buildAllTestsAsStandalone: false
#arcade-specific parameters
condition: always()
continueOnError: false
Expand All @@ -27,8 +30,6 @@ parameters:
enableMicrobuild: ''
gatherAssetManifests: false
shouldContinueOnError: false
compileOnHelix: false
interpreter: false

steps:
- template: /eng/pipelines/common/templates/runtimes/build-runtime-tests.yml
Expand All @@ -38,6 +39,7 @@ steps:
archType: ${{ parameters.archType }}
buildConfig: ${{ parameters.buildConfig }}
testBuildArgs: ${{ parameters.testBuildArgs }}
buildAllTestsAsStandalone: ${{ parameters.buildAllTestsAsStandalone }}
# Build a Mono AOT cross-compiler for non-amd64 targets (in this case, just arm64)
- ${{ if and(eq(parameters.runtimeFlavor, 'mono'), in(parameters.runtimeVariant, 'llvmaot', 'llvmfullaot', 'minifullaot')) }}:
- ${{ if eq(parameters.archType, 'arm64') }}:
Expand Down
8 changes: 8 additions & 0 deletions eng/pipelines/common/templates/runtimes/build-runtime-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ parameters:
archType: ''
buildConfig: ''
testBuildArgs: ''
buildAllTestsAsStandalone: false
#arcade-specific parameters
condition: always()
continueOnError: false
Expand All @@ -18,6 +19,13 @@ steps:
- ${{ if eq(parameters.osGroup, 'windows') }}:
- script: $(Build.SourcesDirectory)/src/tests/build$(scriptExt) $(crossArg) ci ${{ parameters.archType }} $(buildConfigUpper) $(_nativeSanitizersArg) $(priorityArg) $(runtimeFlavorArgs) ${{ parameters.testBuildArgs }} $(runtimeVariantArg) $(librariesConfigurationArg)
displayName: Build Tests
env:
${{ if eq(parameters.buildAllTestsAsStandalone, true) }}:
BuildAllTestsAsStandalone: true

- ${{ if ne(parameters.osGroup, 'windows') }}:
- script: $(Build.SourcesDirectory)/src/tests/build$(scriptExt) $(crossArg) ci os ${{ parameters.osGroup }} ${{ parameters.archType }} $(buildConfigUpper) $(_nativeSanitizersArg) $(priorityArg) $(runtimeFlavorArgs) ${{ parameters.testBuildArgs }} $(runtimeVariantArg) $(librariesConfigurationArg)
displayName: Build Tests
env:
${{ if eq(parameters.buildAllTestsAsStandalone, true) }}:
BuildAllTestsAsStandalone: true
1 change: 1 addition & 0 deletions eng/pipelines/extra-platforms/runtime-extra-platforms-ioslike.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,3 +165,4 @@ jobs:
creator: dotnet-bot
testBuildArgs: tree nativeaot/SmokeTests /p:BuildNativeAOTRuntimePack=true
testRunNamePrefixSuffix: NativeAOT_$(_BuildConfig)
buildAllTestsAsStandalone: true
1 change: 1 addition & 0 deletions eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,3 +139,4 @@ jobs:
creator: dotnet-bot
testBuildArgs: tree nativeaot/SmokeTests /p:BuildNativeAOTRuntimePack=true
testRunNamePrefixSuffix: NativeAOT_$(_BuildConfig)
buildAllTestsAsStandalone: true