Ensure that Arm64 correctly handles multiplication of simd by a 64-bit scalar #106839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Extracted from #106594 so that it can be backported to .NET 9 |
tannergooding
force-pushed
the
fix-106838
branch
from
a5db156 to
f423a26
Compare
This was referenced Aug 23, 2024
tannergooding
force-pushed
the
fix-106838
branch
from
f423a26 to
379dd36
Compare
This was referenced Aug 23, 2024
tannergooding
force-pushed
the
fix-106838
branch
from
379dd36 to
de8b16a
Compare
|
CC. @dotnet/jit-contrib for review This fixes #106838 and will need backport |
EgorBo
approved these changes
Aug 26, 2024
Yes. The issue here was specifically with multiplication by a scalar, since Arm64 handles it by extracting the separate components. For x64, we always broadcast that scalar to a vector and then use a vectorized implementation instead, not extracting. -- The test is notably also xplat, not Arm64 specific and so is also validating that x64 is correct. |
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10562736191 |
Merged
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #106838