[release/9.0] Fix infinite loop in genCreateAddrMode #106766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jeffschwMSFT
approved these changes
Aug 21, 2024
JulieLeeMSFT
approved these changes
Aug 22, 2024
|
Ping @AndyAyersMS for code review for rc2 backport. |
AndyAyersMS
approved these changes
Aug 22, 2024
This was referenced Aug 22, 2024
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #106732 to release/9.0
A customer reported issue (#106607) where an obfuscated app spins forever due to an infinite loop in JIT. It seems that the IL obfuscator is the culprit here since it generated a quite absurd (but valid) IL that JIT had no test coverage for. It is very unlikely it's possible to generate a similar pattern with plain C# since Roslyn does constant folding and overshift handling even for Debug.
/cc @EgorBo
Customer Impact
Impact: IL obfuscators may lead to freezes in the resulting app
Regression
Testing
A test is added. It's unlikely to be possible to hit it with plain C#.
Risk
Low