Revert Update dependencies from https://github.com/dotnet/runtime build 20240819.2 #106729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld 20240819.2 This introduced a dependency on a newer runtime from build tools
ghost
added
the
needs-area-label
ericstj
added
Servicing-approved
|
Marking approved -- need this to unbreak the build. |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
|
I will fast merge as this is a revert. |
carlossanlop
approved these changes
Aug 20, 2024
This was referenced Aug 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduced a dependency on a newer runtime from build tools.
Partial revert from #106620.
The culprit here is MicrosoftDotNetILCompilerVersion - that seems to be bringing in ilc which runs as shared framework app against the toolchain runtime. Introduced in #100845 @elinor-fung @jkoritzinsky
The alternative would be to disable that functionality here.