Inject IJW Copy Constructor calls in the JIT instead of in the IL stubs #106424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…these copies." This reverts commit 79b1cd2.
…he tests in JitStress (as they won't be fixed when the JIT introduces these extra checks when not asking the VM)" This reverts commit 35d0de9.
…d creating shadow vars
…to do the generic method instantiation on every call (only when jitting)
…which the P/Invoke scenario will use)
…gher layers" This reverts commit 390185c.
…he original arg and don't do intermediate copy-constructor calls. The bitwise copies are invalid, but there's no possible way for the user to see them. They'll always get passed a correctly copy-constructed value.
…rguments to the arg slot instead of tracing through locals.
…e parameter of this type will likely have multiple.
…ructor scenarios (by counting args in the correct direction)
jkoritzinsky
changed the title
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jakobbotsch
approved these changes
Aug 14, 2024
|
Looks like there's one spot I missed with callis. There's some place that (only when running lots of the tests for some reason) that the modreqs get dropped in the calli signature. Still need to narrow it down. |
jkoritzinsky
added
the
NO-MERGE
This was referenced Aug 15, 2024
…ructor scenarios (by counting args in the correct direction)
…already depend on a resolver to depend on the new token map
|
Solved the issue, this is ready for review/merge. |
jkoritzinsky
removed
the
NO-MERGE
…rnal modifier" type for modifiers in internal signatures.
jkoritzinsky
force-pushed
the
copy-ctor-jit-inject
branch
from
d1fd184 to
bb9fe1a
Compare
This was referenced Aug 16, 2024
Closed
Closed
AaronRobinsonMSFT
approved these changes
Aug 21, 2024
...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try 2 for #106000 after CI decided to not run on it for some reason.
Fixes Issue #100751 and #100033 by injecting copy constructor calls in the JIT instead of injecting them in the IL and then using special hooks/interceptors to handle non-IL-supported/accessible scenarios.
Re-enable GS checks in Reverse P/Invokes now that we handle them correctly.