ARM64-SVE: Alphabetically order the SVE API (#104834) #105760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the |
ghost
added
|
Note regarding the |
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
a74nh
changed the title
Contributor
Author
|
@dotnet/arm64-contrib @kunalspathak |
| /// svfloat32_t svabs[_f32]_x(svbool_t pg, svfloat32_t op) | ||
| /// svfloat32_t svabs[_f32]_z(svbool_t pg, svfloat32_t op) | ||
| /// </summary> | ||
| public static unsafe Vector<float> Abs(Vector<float> value) { throw new PlatformNotSupportedException(); } |
Contributor
There was a problem hiding this comment.
Is this order using .NET names for types (i.e. Single instead of float)? I'm guessing that's why Vector<float> Abs is at the end?
Contributor
Author
There was a problem hiding this comment.
This is using the order specified here.
So, yes the names instead of the types.
amanasifkhalid
approved these changes
Jul 31, 2024
Contributor
amanasifkhalid
left a comment
amanasifkhalid
left a comment
There was a problem hiding this comment.
Did a quick skim, and this LGTM. Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally there are two issues:
Does not change any APIs or contents within summary blocks.
Also adds some missing section comments.