Ensure that we add the broadcast and mask flags prior to computing the instruction size #105757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e instruction size
ghost
added
the
area-CodeGen-coreclr
tannergooding
commented
Jul 31, 2024
Comment on lines
+7467
to
+7468
| SetEvexBroadcastIfNeeded(id, instOptions); | ||
| SetEvexEmbMaskIfNeeded(id, instOptions); |
There was a problem hiding this comment.
We have 37 instances where we SetEvex information, and this is the only place where it was happening in the wrong spot and is what was causing the size misprediction
amanasifkhalid
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
I've verified locally that this fixes #105693. LGTM, though you may want a review from someone more knowledgeable of these encodings. Thanks!
EgorBo
approved these changes
Jul 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #105693