Ensure that embedded broadcast is correctly checking for EVEX support before use #105659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
Author
|
CC. @AndyAyersMS, the backport just needed to be 1 line here. All the other callsites were correctly filtering based on whether the JIT supported AVX512 already. |
AndyAyersMS
approved these changes
Jul 29, 2024
Member
Author
|
CC. @jeffschwMSFT |
jeffschwMSFT
approved these changes
Jul 30, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we will take for consideration in 8.0.x
jeffschwMSFT
added
the
Servicing-consider
rbhanda
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer Impact
This resolves #96156
.NET 8 introduced support for the new AVX512 instruction set and this brought along support for several optimizations when the underlying hardware supported this feature. However, one such place was missing the check for said hardware support and would cause incorrect codegen on older hardware which could lead to incorrect results and behavior.
Regression
This is a regression as it impacts existing code and hardware when run on the .NET 8 runtime.
Testing
An explicit test was added covering the regression and additional validation was done against other callsites checking
OperIsEmbBroadcastCompatibleto ensure that they were all correctly validating that the target hardware is AVX512 capable.Risk
Low. The failure here is well understood and has had a fix in the .NET 9 previews for almost 2 months now.